• do not show user/help if no 'drupal' module enabled & no Authentication service enabled

Bugs:

  1. when goto /user/-some-text-, then -some-text- is outputed above the login form.
  2. can't enable Authentication service when no mission text
  3. "Note: if you have an account with one of our affiliates (Drupal), you may login now instead of registering.' text is shown even if no authentication service enabled.
  4. Do not show 'Drupal' in user/help when 'drupal' module is enabled but authentication service is disabled. The same must be with any module that implements hook_auth().
CommentFileSizeAuthor
#1 distributed authentication 473.patch.txt5.9 KBdoq

Comments

doq’s picture

doq commented
Component: drupal.module » user.module
Assigned: Unassigned » doq
Status: Active » Needs review
StatusFileSize
new distributed authentication 473.patch.txt5.9 KB

Applies to menu system, user module, drupal module.

  1. FIXED: possible to break Drupal functionality when use links in style of e.g. admin/modules%2523description
    • if you use admin/modules%2523description to access pages then _GET['q'] is set to admin/modules#description and it might show incorrect help.
  2. FIXED: user_auth_help_links() produced links in style of e.g. user/help%2523drupal
  3. FIXED: $msg in user_login(). Why do we need this?? Try accessing your site with user/lfgjgjofgjginfgh%20dfgjgldf%20gkjl%20jfgjkfg%20jkd. Removed.
  4. FIXED: when accessing site with user/login/-some-trash- or user/-some-trash- it doesn't returned 404.
  5. FIXED: checking for drupal_authentication_service in user module (if (variable_get('drupal_authentication_service', FALSE) && count($user_auth_help_links) > 0) {) is incorrect, 'cos other modules might implement authentication services. drupal_authentication_service is just used for 'drupal' module.
  6. FIXED: when Drupal auth service is turned off we can still see the header 'Drupal' at user/help.
  7. FIXED: 'Note: if you have an account with one of our affiliates (******), you may login now instead of registering.' is shown even if no _auth services enabled.
  8. FIXED: user/help is shown even if no any distributed authentication services are enabled.
  9. FIXED: minor performance optimizations

ISSUES NOT FIXED:

  1. After adding new 'Member Login' (user/login) menu item to some bottom links menu, I don't see 'log in' local task any more [But when added 'Member Login' (user) - local task is visible].

FOR DOCUMENTATION:
hook_info() must return FALSE if no auth service is enabled in that module.

doq’s picture

doq commented
Title: user & distributed authentication cleanup » user & distributed authentication bugs
doq’s picture

doq commented

UPDATED.

Applies to menu system, user module, drupal module.

  1. FIXED: possible to break Drupal functionality when use links in style of e.g. admin/modules%2523description
    • if you use admin/modules%2523description to access pages then _GET['q'] is set to admin/modules#description and it might show incorrect help.
  2. FIXED: user_auth_help_links() produced links in style of e.g. user/help%2523drupal
  3. FIXED: $msg in user_login(). Why do we need this?? Try accessing your site with user/lfgjgjofgjginfgh%20dfgjgldf%20gkjl%20jfgjkfg%20jkd. Removed.
  4. FIXED: when accessing site with user/login/-some-trash- or user/-some-trash- it doesn't returned 404.
  5. FIXED: checking for drupal_authentication_service in user module (if (variable_get('drupal_authentication_service', FALSE) && count($user_auth_help_links) > 0) {) is incorrect, 'cos other modules might implement authentication services. drupal_authentication_service is just used for 'drupal' module.
  6. FIXED: when Drupal auth service is turned off we can still see the header 'Drupal' at user/help.
  7. FIXED: 'Note: if you have an account with one of our affiliates (******), you may login now instead of registering.' is shown even if no _auth services enabled.
  8. FIXED: user/help is shown even if no any distributed authentication services are enabled.
  9. FIXED: minor performance optimizations

ISSUES NOT FIXED:

  1. After adding new 'Member Login' (user/login) menu item to some bottom links menu, I don't see 'log in' local task any more [But when added 'Member Login' (user) - local task is visible].
  2. can't enable Authentication service when no mission text

FOR DOCUMENTATION:
hook_info() must return FALSE if no auth service is enabled in that module.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

Is it possible to break this into separate patches (filed in separate issues) at all? I'm having trouble matching things 'FIXED' with code.

slimandslam’s picture

slimandslam commented

Excellent patch!

magico’s picture

magico commented
Version: 4.7.3 » 5.x-dev
Category: task » bug
Priority: Critical » Normal

It's strange a critical bug, stays like this in the queue...
Following drumm, doq can you broke this into separate patches and if possible reroll against 5.x-dev?

Note: pushing this to 5.x-dev because I've confirmed some of the points in this branch.
1. going to ?q=admin/build/modules%2523description shows an empty page
1.1. with ?q=admin/build/modules/sometext gives Fatal error: Cannot use string offset as an array in E:\xampplite\htdocs\drupal-5.0\modules\system\system.module on line 1431
3. confirmed.
4. confirmed.

ricabrantes’s picture

ricabrantes commented
Version: 5.x-dev » 6.x-dev

1. Fixed in D5.x-dev
1.1 Fixed in D6.x-dev

ricabrantes’s picture

ricabrantes commented
Status: Needs work » Fixed

opsss FIXED

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.