Secret key variable is never used

Patch is not attached.

On ubuntu the standard varnish startup script includes a secretfile.
I've tested the patch and it works fine when using a secret, thanks.

Personally I'd omit the watchdog call on success, but call it only on failure like it's done a bit lower.

if ($status['code'] != 200) {
  watchdog('varnish', t('Authentication to server failed!'));
  return FALSE;
}

The patch needs to be cleaned up (indenting, if (), string concatenation etc) to fit the coding standards ;)

Cleaned up and integrated. Thanks for taking the lead on this!

This was not fixed or was broken again. There is no declaration of $secret hence no secret is used.

20-Jul release needs the $secret declaration back.

The code should read like this in varnish.module at line 208:

    // Do we need to authenticate?
    if ($status['code'] == 107) { // Require authentication
      $secret = variable_get('varnish_control_key', '');
      $challenge = substr($status['msg'], 0, 32);
      $pack = $challenge ."\x0A". $secret ."\x0A". $challenge ."\x0A";
      $key = hash('sha256', $pack);

      socket_write($client, "auth $key\n");
      $status = _varnish_read_socket($client);
      if ($status['code'] != 200) {
        watchdog('varnish', 'Authentication to server failed!', array(), WATCHDOG_ERROR);
      }
    }

+1 for #7. Patch attached, if the one-line addition above isn't obvious enough.

I couldn't get authentication with varnish working. Or rather, applying the above patch and putting my secret key into the drupal varnish config page worked...but then broke after a few days. Could just be my setup, though - I ended up restarting varnish without the secret key required (and making sure my firewall settings only allow access from the correct ip). The module authentication algorithm looks like it follows the varnish documentation at
http://www.varnish-cache.org/trac/wiki/CLI#Authentication:Thegorydetails

...so is this just me? Can someone else get varnish authentication working?

+1 for patch #7/#8 Thanks!

Ran into this, patch is fine, RTBC.

Patch is good.

Yep, patch in #8 works for me.

+1 for this patch

Patch tested. Works OK!

patch works fine!

+1 for patch (#8)

Commited! Thanks for your work, and for your patience =)

Lovely.