Posted by Stefan Nagtegaal on August 27, 2006 at 1:39pm
16 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | statistics.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Dave Reid |
| Status: | closed (fixed) |
| Issue tags: | Usability |
Issue Summary
Right or wrong?
IMO this doesn't belong under 'Logs'...
(enable statistics.module to see this happen)
Comments
#1
Agreed, patch attached.
#2
This patch breaks the alphabetical order of menu items for me, see attached screenshot. +1 for the concept
#3
Ah true, I needed to remove the weight from the menu item, which was causing it to be at the end of lists.
#4
I'm not sure I agree. Comment settings are in the comments section too.
#5
Perhaps the comment settings page should be moved too, but it makes more sense in that case because it's a tab rather than a basic menu item. I would prefer to stick to statistics in this issue though.
One of the best usability improvements in 5.0 imo is the reorganization of admin into sections. We should default to using the appropriate categories unless there is a good reason not to. In the case of the statistics settings I don't see a compelling reason to diverge from the standard location.
#6
I'd add a +1 for this. I was just trying to set up statistics, and the settings weren't under 'site configuration' where I had initially looked. It took me a while to spot them under 'logs'.
#7
also there is a confusion here for 'not brainy' ones like myself :)
you can not see statics on the settings + statics actually called 'logs' logs are synonymous to stats but 'statistics' is more generic naming and suits better -imo no need for confusion -unless i am getting all wrong here and actually statistics and logs are entirely different things :)
also if you install Xstatistics.module as an extention to your statistics (logs) and activate the its block and your statistics not activated it'll give u a link -plase activate your statistics and link to
> /admin/settings/statistics
well thats where the Xstatistics.module developer thought it should be!! but its not there of course, instead its here
> admin/logs/settings
imho - the url dir. pattern should not break (without url redirect fix)
and logs should be under statistics - to give to other stat options more than logs
> admin/settings/statistics/logs
and listed under general settings page
-just some thought maybe there are more important reasons for to keep current way and there is a reason for not to do so as above
thanks
#8
I think we should leave the menu rearrangements to the development versions of Drupal, currently 6.x.
#9
I think, this will not make it into drupal 6
#10
Make sense.
#11
#12
#13
it makes total sense for me
i had this problem many times to find this setting
i runned the tests of the statistic module:
36 passes, 0 fails, and 0 exceptionsanyone else?
#14
code looks good
#15
"Access log settings" looks out of place with the other items here. See screenshot.
And probably, I would look for this under "Statistics," not "Access log" since I enabled the "Statistics" module?
#16
#17
+1 to "Statistics" settings since it is the name of the module. This menu item location has always irked me in D5/6. Attached patch fixes all the references to admin/reports/settings that were missed before and adds a much needed 'administer statistics' permission for the moved admin/settings/statistics.
#18
The last submitted patch failed testing.
#19
Testing #17 and it installs and works for me. Setting back to code needs review for re-testing.
#20
#21
Committed to CVS HEAD. Thanks!
#22
What about moving the statistics out of the admin pages, so site administrators may decide to make them public using permissions? A lot of sites, however not the majority, have made their statistics publicly available.
#23
An interesting idea, but needs a separate issue. :)
#24
Done: #362834: Move statistics out of the administration pages and add permissions.
#25
Automatically closed -- issue fixed for 2 weeks with no activity.