robbdavis [robbdavis]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme; for modules it should include also a comparison with the existing solutions, while for themes a screenshot is also required.
Does the theme output HTML 5 tags?

The theme doesn't pass the W3C validation. That is the result of the validation when set the document type to HTML5; if I let the validator detect the documentation type, I get this result.

The difference is that Drupal output is XHTML 1.0 transitional, which is not compatible with HTML 5.

Code review with coder module set on normal:

email-validator.php
Line -1: Include the CVS keyword $Id$ in each file. This should be in the format // $Id$ or // $Id$ <a href="http://drupal.org/coding-standards">Drupal Docs</a>
Line -1: @file block missing <a href="http://drupal.org/node/1354#files">Drupal Docs</a>
Line 43: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 45: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 54: missing space after comma
Line 55: missing space after comma
Line 59: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 61: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 66: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 71: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 75: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 89: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 103: missing space after comma
Line 104: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 107: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 118: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 123: missing space after comma
Line 126: missing space after comma
Line 127: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 128: else statements should begin on a new line
Line 131: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 136: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 140: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 144: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 148: the final ?> should be omitted from all code files
Line 158: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
Line 159: else statements should begin on a new line
Line 160: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE

block.tpl.php & node.tpl.php & template.php
Line -1: Include the CVS keyword $Id$ in each file. This should be in the format // $Id$ or // $Id$ (<a href="http://drupal.org/coding-standards">Drupal Docs</a>)
Line -1: @file block missing (<a href="http://drupal.org/node/1354#files">Drupal Docs</a>)

page.tpl.php
Line -1: Include the CVS keyword $Id$ in each file. This should be in the format // $Id$ or // $Id$ (<a href="http://drupal.org/coding-standards">Drupal Docs</a>)
Line -1: @file block missing (<a href="http://drupal.org/node/1354#files">Drupal Docs</a>)
Line 39: missing space after comma

I think most of that should be quick to fix, but in all fairness there's some themes in contrib that don't follow strict Drupal coding standards, so I would approve this application, would love to see this theme in contrib.

By the way "Line -1: @file block missing" I don't think is applicable because I rarely see this on a contrib theme.

As much as I'd love to see more HTML5 in Drupal, this has some issues...

I'm not sure, but I don't think you can include that font on Drupal's CVS, since it has a non-GPL license. You could include instructions to download it, but I suspect that may be too much work for most people wanting to use a contrib theme. I'd suggest either finding a suitable replacement already on a hosted font service (e.g. Google), or finding a reliable host and pointing to that by URL.

The images and stylesheet appear to come from here, which has an informal "use this for whatever projects you want" kind of release, but no formal license, and an explicit statement of "You're not allowed to upload the theme elsewhere for download" which uploading to Drupal.org seems to violate. I'm not sure if this counts as a 3rd party "library" or if it presents legal or GPL-compatibility issues for hosting on Drupal.org but it seems questionable enough to figure it out before approving this application.

Also, assuming the licensing issues can be dealt with (though I'm not very confident they can), you'll probably need to come up with a new name for this, as there's already a module named "HTML5" and naming conflicts can happen between modules and themes. While "html5" may seem somewhat descriptive right now, you might consider that it will some day be only slightly less vague than naming the theme "theme."

As reported in Drupal Contributions Repository - Terms of services

All content submitted to the repository is automatically assumed to be licensed
under the GNU/GPL. Any content that is not licensed under the GNU/GPL should
not be added to the repository and when found it will be removed by the owner.

This license is compatible with the GNU so it should not be a problem bundling it with the theme.

As reported from the requirements and http://drupal.org/node/539608, license compatible with GPL License are not accepted in drupal.org.

So the original developer of this theme has agreed in writing (well, technically in typing) to allow it to be released on drupal with a GNU license.

I would suggest to make a note about that in the README.txt file, to avoid somebody report that once the project is created.

I am closing this issue due to lack of replies.

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.