Hi all!

The default PickupType code "01" is incorrect for our situation, and using it would cause us to hemorrhage money every time we shipped something from our store since it comes up with a radically incorrect rate.

More specifically, 01 seems to be the daily pickup option, which does not describe our situation. In our case, we need it to be "03", since we'll be shipping packages individually.

We've got the change hard-coded right now, since we're shooting for a grand-opening this week, but next time we upgrade it will break again.

Is there any way we can make this configurable any time soon?

Thanks for E-Commerce - it rocks!
--Alex Markley

CommentFileSizeAuthor
#4 ups.inc_3.patch3.06 KBkemayo
#2 shipcalc-ups-pickuptype.patch1.74 KBnedjo

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Needs review

Yes, this is noted as a Todo in the code.

Here's a quick untested patch. malex, can you can test and report back?

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
StatusFileSize
new shipcalc-ups-pickuptype.patch1.74 KB

With patch this time. Patch is for 4.7 (I'll do a HEAD as a followup when this is ready to apply.)

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Looks good nedjo thanks for the work. If someone doesn't get around to it I'll commit this later this week.

kemayo’s picture

kemayo commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new ups.inc_3.patch3.06 KB

The previous patch was missing a variable_set for the pickup type. In addition, some of the pickup types require a customer classification. Here's a patch which fixes that and allows you to select the classification.

sime’s picture

sime
any/any
Location Melbourne
commented
Status: Needs review » Reviewed & tested by the community

nedjo, your call

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

The patch looks good to me, though I haven't tested it. It should be applied first to HEAD. I'll do so when I get a chance, or anyone else pls feel free.

aserdaten’s picture

aserdaten commented

Does this affect residence vs. business delivery?

brmassa’s picture

brmassa commented
Status: Reviewed & tested by the community » Fixed

Guys,

commited on eC4 CVS

regards,

massa

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.