rasantiago [rasantiago]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme; for modules it should include also a comparison with the existing solutions, while for themes a screenshot is also required.

There have not been replies in the past week. I am marking this application as won't fix.

I didn't get an email notification for comment #2. Here is a more detailed description:

Domain Context module is an integration module for the Domain Access module and the Context module.

The Domain Access module allows administrators to set specific settings for each of their domains that are using the same code base. The Context module allows you to target blocks to regions (and more) given certain conditions that can be set in the Context admin. Currently when both modules are installed you have no interface that will allow you to trigger a Context on a specific Domain. This module utilizes the $_domain global variable exposed by the Domain module and adds the Domain condition to the Context admin that will allow you to trigger a Context on a specific Domain.

If you do not want to use Context to target blocks to a Domain, check out the Domain Blocks module

Please check out our new description.

Minor notes:

-No need to include LICENSE.txt when you commit to CVS. Drupal.org adds it for you.
-There's some commented-out code that should be removed, e.g., domaincontext_init()

I don't have specific experience with the context API, but I've used both Context and Domain Access and this looks useful. I've done a casual security review, and don't see any obvious issues. The module uses provided APIs consistently.

If someone else can toss this in a sandbox and make sure it works as advertised, I say RTBC.

Thanks Matt! Commented out code removed.

I'm taking a look through the code now. Here are my thoughts:

• The info file lists version and project. These should be removed as they are automatically added by D.O.
• The license file is still included and should be removed.
• You have ctools listed as a dependency but never really use ctools directly. You have the ctools plugin hook to integrate with the context module that already requires ctools. You can leave the ctools dependancy out.
• The code looks clean when it comes to Drupal coding standards.
• The code works as advertised.

I am changing status as per previous comment.

Any progress on approving the rasantiago account and this module?

I'll say that I am going to use this module, and hope it becomes a contrib module soon :)

(+ subscribe)

**knock** **knock** Anyone here to approve this module? :)

I'm also interested in seeing this approved. Subscribing.

+1

As the Domain Access maintainer, I expressly asked that this module be split, since I cannot support Content integration questions. See #689972: Context module support.

There is nothing in the code that should delay this application.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

I have created this project and added it to CVS. A development snapshot will be available within the next 24 hours for testing. I will transfer maintainership if/when rasantiago is available.
http://drupal.org/project/domaincontext