I have three newsletters that appear on the registration form. If a user subscribes to just one they get receive multiple subscribe confirmation messages. They are only subscribed to one list in Campaign monitor.
The attached patch adds some logic to the success message so its only displayed for newsletters they actually subscribe to.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | campaignmonitor-duplicate_messages-3x-810786.patch | 3.4 KB | crea |
| campaign_monitor_remove_duplicate_subscribe_messages.patch | 700 bytes | rsaddington |
Comments
Comment #1
rsaddington commentedComment #2
crea commentedSince there's no list name in the message, one message should be enough in all cases. Why repeat it at all ?
Comment #3
crea commentedComment #4
crea commentedHmmm, there are many duplicated messages. It's actually better to keep the problems separated..
Comment #5
crea commentedOriginal patch in this issue could fix the problem partially, but it actually approaches it from the wrong side (IMHO). There are places where subscription functions are mistakenly called several times (e.g. #955056: Drupal message says "You have been successfully subscribed" even if you haven't) , so it's better to fix those places rather than to modify the subs./unsubs. functions.
Duplicate messages also show when there are subsequent subscription to several lists (which is a valid usecase), and the original patch does not address that.
Comment #6
crea commentedThis patch uses simple approach to fix all duplicates. We can simple show each error/success message only once cause they are general and don't contain unique information.
Comment #7
cableman0408 commentedThe issue have been fixed in the development branch and is based on the patch. Thanks