Tagging is a great module with a lot going on. It would be great if this could be compatible here.

Thanks.

http://drupal.org/project/tagging

CommentFileSizeAuthor
#2 2010-05-28_810798_support_tagging_module[unix].patch1.29 KBarhak

Comments

arhak’s picture

arhak commented

leaving a note to myself: form element tagging_widget

arhak’s picture

arhak commented
Title: Tagging Module » support Tagging Module (driven diff for tagging_widget)
Project: Comment driven » Driven API
StatusFileSize
new 2010-05-28_810798_support_tagging_module[unix].patch1.29 KB
arhak’s picture

arhak commented
Status: Active » Needs review
ManyNancy’s picture

ManyNancy commented

Ahh, I was trying to find this issue on the comment driven list and wondering where it went.

The tagging widget shows up correctly and I was able to type in a term, press enter, have the term appear. But it the comment driven stuff doesn't happen when I press save, it's as if the tagging widget is totally ineffectual in the driven properties.

Thanks.

arhak’s picture

arhak commented
Status: Needs review » Needs work

ops, sorry
it was a long shot
I saw preview worked and didn't test actual submission

PS:

I was trying to find this issue on the comment driven list and wondering where it went

yeah, sorry for that too, but the patch goes for Driven API, so I had to move it

arhak’s picture

arhak commented
Status: Needs work » Postponed (maintainer needs more info)

well, it is working for me (preview and submission as well)
and it doesn't seems to be such a "long shot", since its code states:

  // Well this is the original. We actually just need it in the background, so that we
  // dont need to fight in the validation filter. We can let the normal taxonomy.modul
  // validators and submitters do their job.
  $element['#type'] = 'hidden';

are you using it for taxonomy or for CCK (with content_taxonomy perhaps)?
I'll need more details

ManyNancy’s picture

ManyNancy commented
Status: Postponed (maintainer needs more info) » Fixed

What the, I swear I applied the patch before testing it? Brain fart it looks like, the patch didn't get applied when I posted #4. Tried it again and it works.

arhak’s picture

arhak commented
Status: Fixed » Reviewed & tested by the community

perhaps you patched cdriven instead of Driven API ?

PS: still not committed to HEAD, so leaving it RTBC

arhak’s picture

arhak commented
Status: Reviewed & tested by the community » Fixed

committed to HEAD

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.