vdel (and possibly other functions) crash on Drupal 5 [#810974]

Running variable-delete on a Drupal 5 sites results in Drush getting stuck in a loop until it runs out of memory and crashes.

The problem is the db_result() function. In Drupal 6, it returns one field and advances to the next row. In Drupal 5 and earlier it simply returns the first field in the first row and does not automatically advance. So trying to use something like while($x = drush_db_result($result)) results in an infinite loop.

I've fixed this be updated drush_db_result to check if the version is <= 5 and in that case to use db_fetch_array to get values out of the query instead.

Eli

Comment	File	Size	Author
#6	drush-810974.patch	617 bytes	jonhattan
#4	drush_db_result_d5.patch	402 bytes	eli
	drush_fix_db_result.diff	1.16 KB	eli

Comments

Comment #1

moshe weitzman commented 27 May 2010 at 15:41

Status:

Needs review

» Fixed

I reworked this code for a case statement and better coding standards around if statement whitespace and braces. Committed. Thanks.

Comment #2

jaydub commented 2 June 2010 at 21:31

Status:

Fixed

» Needs work

I ran into this as well. I backported just the change that was added in commit http://drupal.org/cvs?commit=372162 but that does not fix the issue. The patch above which returns FALSE if there are no results does work. The commit does not include the return FALSE and so the infinite loop continues and out of memory error is returned.