In some testing, we ran into issues with context.

It seems similar to #633778: Conflict with themes implementing theme_blocks() ; posting here to connect the dots.

CommentFileSizeAuthor
#5 hexagon-811152.patch1.32 KBdvessel

Comments

dvessel’s picture

dvessel commented

Interesting, Hexagon does override theme_blocks. I'll look into it.

dvessel’s picture

dvessel commented

There's a mention in the code comments that any theme overriding theme_blocks is responsible for adding that functionality back in.

There really is no clean way for Context do this on its own. The only alternative is to create a plug-in for hexagon and have it enabled whenever it detects Context. Simply a compatibility plug-in so it's not hard coded into the main theme.

bonobo’s picture

bonobo commented

RE:

The only alternative is to create a plug-in for hexagon and have it enabled whenever it detects Context. Simply a compatibility plug-in so it's not hard coded into the main theme.

Does this seem like the most effective way around this?

Are there any down sides to this approach?

I like the idea of having it be a compatibility plugin. Does this also mean that it could be enabled/disabled via the .info file?

In short, this seems like the way to go.

dvessel’s picture

dvessel commented

No downsides at all and the plug-in can be enabled automatically. It's not set-up to be detect anything automatically at the moment but that would be 10 lines of code changes at the most. I've been thinking about compatibility plug-ins for a while and I think this ability to auto enable would be a big help.

I'll create the plug-in right away.

dvessel’s picture

dvessel commented
Status: Active » Fixed
StatusFileSize
new hexagon-811152.patch1.32 KB

I committed the plug-in. Should be in the 6.x-1.x-dev download link shortly.

And this patch is what I changed for the auto-loading. There was another patch right before this one that fixed a few more bugs.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.