Hi,
I've found a problem with the opening and closing divs not matching up in the gmaps address fieldset. If the 'map' element is not displayed then the generated html is missing a closing div which can break many themes.
The error is that the additional opening div is added to $element[$first_part]['#prefix'] but the corresponding closing div is added to the end of $element['map']['#suffix']. So when $element['map'] is not used in the form the closing div is not rendered and this breaks the theme. The closing div should instead be added to the end of $element[$part]['#suffix'].
I've made a patch against the latest dev, dated 19th May to correct gmaps/includes/gmaps.address-element.inc.
Jonathan
| Comment | File | Size | Author |
|---|---|---|---|
| _gmaps.missing_div.d6.patch | 908 bytes | jonathan1055 |
Comments
Comment #1
jonathan1055 commentedForgot to set it to 'needs review'
Comment #2
xmarket commentedhttp://drupal.org/cvs?commit=375312
Comment #3
jonathan1055 commentedThanks
Jonathan