Could also be done using sections module etc, but adding a whole extra module for this seems silly.

CommentFileSizeAuthor
#6 811338-use_admin_theme_6.patch1.27 KBxurizaemon
#4 811338-use_admin_theme_2.patch1.23 KBxurizaemon
#1 811338-use_admin_theme.patch1.17 KBxurizaemon

Comments

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
StatusFileSize
new 811338-use_admin_theme.patch1.17 KB

patch

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Active » Needs review

i really really really have to write a greasemonkey that doesn't let me add a patch without reminding me to set "needs review" :P

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

Makes sense, but shouldn't that be arg(2) == 'access' ? I wonder whether this patch really works?

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
StatusFileSize
new 811338-use_admin_theme_2.patch1.23 KB

totally true, this is what it oughta be

admin.css may be redundant too?

fago’s picture

fago
Primary language German
Location Vienna
commented

Sry for not noting before, the comment misses the ending point "." - probably the rest of the module doesn't follow this yet, but let's do it at least for new code.

Also an @see system_init() would be good. The .css should be fine as the system module does it too, though I don't know what for.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Needs work » Needs review
StatusFileSize
new 811338-use_admin_theme_6.patch1.27 KB
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.