Closed (fixed)
Project:
PHPMailer
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 May 2010 at 10:02 UTC
Updated:
14 Aug 2016 at 02:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
elliotttf commentedHere's a first crack at this. There's still a lot of work that needs to be done, but I have confirmed that this works for normal mail (didn't try mime mail).
Also, I had issues getting the libraries to load correctly using the dev version of libraries API (might just have been user error) so I patched this from the 2.x branch.
Comment #2
sunHey, good start!
Attached patch makes the module basics work. I didn't review the class changes in detail though. I have the impression that it might be duplicating some code that actually lives elsewhere in the class already, but again, didn't carefully review that, so I might be wrong.
Comment #3
podarokyes
duplicated!
Comment #4
podaroksorry, my mistake - wrong thread
Comment #5
sun#1018226: PHPMailer is currently disabled. Unable to send email has been marked as duplicate. Attached patch is a cleaned up version from @Michael Lopez' patch. Mainly for reference, the usage of static methods doesn't look right.
Comment #6
sunAttached patch is the same as #2 with some very minor clean-ups/reverts.
Comment #7
sunCommitted attached patch to 7.x-3.x.
Didn't look into MimeMail integration yet. MimeMail seems to contain major changes between D6 and D7.
Comment #8
internetdevels commentedNotice: Undefined index: sender in mimemail_phpmailer_send() (line 28 of /path/to/site/sites/all/modules/phpmailer/includes/phpmailer.mimemail.inc).
Notice: Undefined index: address in mimemail_phpmailer_send() (line 36 of /path/to/site/sites/all/modules/phpmailer/includes/phpmailer.mimemail.inc).
Module tries to use $message['sender'] and $message['address'] variables instead of $message['from'] and $message['to']. Fixed in patch.
Comment #9
sunThanks, @InternetDevels.Com -- committed #8 including an E_STRICT warning fix to 7.x-3.x.
Does the MimeMail integration fully work already?
Comment #10
oadaeh commentedI'm going to chime in here, as it seems to be the correct place.
I've created a patch to make PHPMailer work with Mime Mail.
In it are these changes:
Comment #11
oadaeh commentedI just found #1072418: Mimemail's hook_mailengine() return value has changed (I guess Drupal's search doesn't return words with the search term embedded in them -- I thought it did), which is a patch for handling the 'list' $op. I can recreate my patch, removing that part, if desired.
Comment #12
kars-t commented+1 for the patch in #8. Works with mimemail.
One minor change: As far as I see in the mimemail module we can remove "name" and "description" from hook_mailengine(). This is replaced by "list".
Comment #13
marcusx commented+1 for the patch in #12. Works with mimemail.
I also used the latest phpMailer Version 5.2.0 from
http://code.google.com/a/apache-extras.org/p/phpmailer/downloads/list
which seems to work ok.
is the information on the project page...
Comment #14
smk-ka commentedThanks for confirming! Committed #12 to 7.x-3.x.
Comment #16
anrikun commentedIs any official release planned?
Comment #17
oadaeh commentedThere is a Drupal 7 port. Discussion about an official release can be continued on #2297403: Plan for PHPMailer 7.x stable release
I'm restoring the status.