Errors when having textlinkads enabled, but no ads sold.

Thanks. I'll look into it.

Is data representing your links to be found in the table after it is created?

Mmmkay. I guess I didn't test the case where there were no links. You're running PHP5, right?

I'll do my best to look into this over the weekend. Thanks for your patience.

Here's the offending XML returned by the TLA server for my publisher account (no ads yet.)

<?xml version="1.0" ?>
  <Links>
  </Links>

So, the function textlinkads_update_links() needs to handle this condition (no child elements of the <Links> element.

Please test and see if this minor change addresses all of the problems reported (posting patch here, but commited to CVS already):

diff -u -F^f -r1.1.4.4 textlinkads.module
--- textlinkads.module  24 Aug 2006 13:00:18 -0000      1.1.4.4
+++ textlinkads.module  18 Sep 2006 17:50:06 -0000
@@ -318,8 +318,8 @@ function textlinkads_update_links($url, 
   db_query("DELETE FROM {textlinkads}");
   $parser = new xml2array();
   if ($data = $parser->parseXMLintoarray($xml)) {
-    // there is just one link
-    if ($data['LINKS']['LINK']['URL']) {
+    // there are no links or just one link
+    if (count($data['LINKS']) > 0 && $data['LINKS']['LINK']['URL']) {
       $links = array($data['LINKS']['LINK']);
     }
     else {

Thanks for the excellent information. Let's try two things so that I can understand what is happening:

  // Thing number 1: what is in xml?
  dprint($xml); // you need the devel mod for dprint

  // (still Thing number 1): does trimming $xml help in any way?
  trim($xml);

  if ($data = $parser->parseXMLintoarray($xml)) {
    // there are no links or just one link

    // Thing 2: since you're getting a string at this point, let's try building an !is_string() into the logic
    // We can't use is_array because in PHP5 strings are arrays
    if (!is_string($data) && count($data['LINKS']) > 0 && $data['LINKS']['LINK']['URL']) {

If you don't mind, I'd really like to get this cleared up... thanks for your help.

Shouldn't

  // (still Thing number 1): does trimming $xml help in any way?
  trim($xml);

be

  // (still Thing number 1): does trimming $xml help in any way?
  $xml=trim($xml);

according to http://us3.php.net/trim (and my tests verify this) trim() doesn't modify the original string. So..

I will check out your suggestions later - I really can't do anything with this right now.

Is it possible for you to build a dummy test XML string with my data for debugging purposes.

Change:

 $xml = textlinkads_file_get_contents($url, $time_out);

to:

 $xml = "<?xml version=\"1.0\" ?>\n<Links>\n</Links>\n";

This is a patch that fixes 2 errors that appeared in cron.php
The first part gets sure $data['LINKS'] is an array before accessing it, the second part makes $links an array just in case $links doesnt get populated by successive query.

Updating status. Please review the patch.

I update Textadlink module and now show me these warning.

user warning: Table 'we_drpl1.textlinkads' doesn't exist query: SELECT * FROM textlinkads WHERE text IS NOT NULL && beforetext IS NOT NULL && aftertext IS NOT NULL LIMIT 4 in /home2/we/public_html/huajuapan/includes/database.mysql.inc on line 120.

What kind of error? Can you post it here?

I continue to get a similar error that was posted earlier. No ads currently being posted through textlinkads. Here is the error (slightly modifided):

Invalid argument supplied for foreach() in ../modules/textlinkads/textlinkads.module on line 329.

Bryan

warning: Invalid argument supplied for foreach() in /home/centerne/public_html/modules/contrib/textlinkads/textlinkads.module on line 329.

i am still getting this error - where is this fix??

thanks

I see this, too, on my site(s) having no ads.

For the record, again, here's what the data looks like on a site with no ads:

  <?xml version="1.0" ?> <Links> </Links>

So, the existing code assumes that there are child elements of <Links> named <Link>; when this is not true, $links = ' ' (a single-character string) and the foreach fails since $links is not an array. The code needs to deal with non-existent child data, which as far as I can see, it does not in the current version.

Attached is a patch against the 4.7 code base that fixes the foreach problem on my site.

Please review and comment.

Marking as normal priority, since this not that big of a problem (except for annoying error reports in the watchdog log)

Thanks for the bugfixes.

The reason there is no HEAD version is because I dislike the (now outdated) paradigm of the "versionless" HEAD. I usually only comitted versions that worked with actual distributions (4-6, 4-7, etc.).

Ah, thanks for the CVS version explanation. Problem is, it took me a few minutes to figure out why my CVS client was failing on checkout (defaults to the current head revision), so it wouldn't get any files. I had to manually specify the DRUPAL-4-7 branch before I could get the files from CVS.