Hi

I noticed that instructions for updating module from 4.7 to 4.8 at http://drupal.org/node/64279#hook-settings are not correct. The code that is writtne there does not work.
Wrong:

 $items[] = array(
    'path' => 'admin/settings/your-module',
    'title' => t('your ole ola'),
    'callback' => 'yourmodule_admin_settings',
    'access' => user_access('administer site configuration'),
    'type' => MENU_NORMAL_ITEM,
   );

Correct:

 $items[] = array(
    'path' => 'admin/settings/your-module',
    'title' => t('your ole ola'),
    'callback' => 'drupal_get_form',
    'callback arguments' => array('yourmodule_admin_settings'),
    'access' => user_access('administer site configuration'),
    'type' => MENU_NORMAL_ITEM,
   );

I hope I put it right.

Comments

pwolanin’s picture

For the example code that's given, i think you are correct and I'll update it. Obviously, in general, a callback can be any function, not just drupal_get_form.

pwolanin’s picture

Status: Active » Fixed

also corrected the call to system_settings_form, which now only takes $form as an argument.

Anonymous’s picture

Status: Fixed » Closed (fixed)