On the dblog page at /admin/reports/dblog, the td's in the active column get a red (#eeb9b9) background color if the status of the log message is 'error'.
However, in Seven this only happens on even rows (see attached screenshot), because the background color on odd rows is reset to #f3f4ee on line 527 of style.css:

table tr.odd td.active {
  background: #f3f4ee;
}

I'd love to submit a patch but I'm not sure which color it should be. Are there official design files for this?

CommentFileSizeAuthor
#3 813516.patch671 bytesasrob
#2 broken_warning.png23.71 KBnevergone
#1 dblog-error-odd-F3CDCD.png12.84 KBmarcvangend
dblog-error-odd.png15.99 KBmarcvangend

Comments

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented
StatusFileSize
new dblog-error-odd-F3CDCD.png12.84 KB

The difference between the normal even/odd background colors in the active column is +13 Luminosity in the HSL color space. We can derive odd-row colors from that for the colors of all severity levels.

There is one complicating factor: Both the severity level and the zebra striping are coded as classes on the <tr> element. The cleanest way to apply the colors would be this:

table tr.odd.dblog-error td.active {
  background-color:#F3CDCD;
}

(See the attached screenshot for the result.) Unfortunately, this type of css selector (multiple class names) is not supported by IE6 and before.

nevergone’s picture

nevergone
Primary language Hungarian
commented
StatusFileSize
new broken_warning.png23.71 KB

Warning message is broken:

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 813516.patch671 bytes

I fixed, please test it.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Thanks for reminding me, I forgot about this issue...

Asrob, I'm afraid we cannot use this fix, because we say that we support IE6 in core themes. I think we need extra classes.

Jeff Burnz’s picture

Jeff Burnz commented

Well... IE6 support only has to be to the extent that its not broken, certainly doesn't need to be perfect. Bartik as a transparent png logo which looks horrid in IE6, and while this is a bit more serious since its error and warning messages etc I could live with the chained selectors. You could also give IE6 some brutal override so they were all one color (no odd/even striping). Put it this way - should we fix this now for the majority and leave a dying browser with something OK, or leave looking bad for everyone - cause time is running out :)

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Thanks Jeff. I do consider the situation from the screenshot broken, because it's bad for usability. So, IMO it needs to be fixed for IE6 as well. But you're right, we can just introduce the nice styling for modern browsers and pick a single color for IE6 only. That way we don't need to add extra classes to the markup.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs review » Needs work

OK sounds good, so we need a patch that:

- sets the nice styles like the patch in #3 for modern browsers using chained selectors
- add an override for IE6 to use just one color

Are there any other status's that we need to think about such as OK, Content, User - are they all looking right?

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Jeff: yes that's what we need to do. We indeed need to check all types of message levels. While we're at it, let's check other core themes as well.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.