In particular, Aquasoft, but I've seen problems in others as well.

For example, Collapsable blocks don't work. In my debugging, I've found that the jstools code relies on certain standard structure and naming practices be followed for it to have the desired effects. While many newer themes follow these, some do not.

In particular, for collapsable blocks, the block must be enclosed in a div tag with a class type of block. Inside it, there must be another div tag with a class name of content. And if that is not enough, the heading text for the block must be in an h2 tag. Aquasoft follows none of these conventions.

So I'm not sure if this is a bug in Aquasoft or in jstools or if there is a need for a well designed set of rules for themes in Drupal that needs to be better communicated.

In the interrim, perhaps jstools can be generalized through settings to handle the various cases. Or perhaps jstools can propose some standard way that enables a theme to inform jstools about the tags and structure the theme will emit.

CommentFileSizeAuthor
#2 cc_screen_bug.png206.29 KBliza

Comments

krzysiek@palikowski.vel.pl’s picture

krzysiek@palikowski.vel.pl commented

I confirm that collapsible blocks and active menu can mess with collapsible panels in drupal - they worked for some time and suddenly stopped to work for some time... after i cleaned cache and logged off/on - it works again :) ... strange?

liza’s picture

liza commented
StatusFileSize
new cc_screen_bug.png206.29 KB

Same here.

I am using a customized theme based on Marvin2k PhpTemplate. The theme and collapsiblocks work fine in Firefox and Safari. For some bizarre reason, not only do the blocks don't collapse in IE, but the top three boxes on the far-left sidebar disappear.

joel_guesclin’s picture

joel_guesclin commented

I'm trying to get this to work on 4.7.4 using standard Bluemarine theme. The block definition seems to correspond to what is said in above, eg:

        <div class="block block-event" id="block-event-1">
    <h2 class="title">Upcoming events</h2>

    <div class="content"><div class="item-list"><ul><li>no upcoming events available</li></ul></div><div class="ical-link"><a href="webcal://localhost/drupal-4.7.4/event/ical" title="Add this calendar to your iCalendar"><img src="/drupal-4.7.4/modules/event/images/ical16x16.gif" alt="Add to iCalendar" /></a></div><div class="more-link"><a href="/drupal-4.7.4/event" title="More events.">more</a></div></div>
 </div>
  <div class="block block-comment" id="block-comment-0">
    <h2 class="title">Recent comments</h2>
    <div class="content"><div class="item-list"><ul><li><a href="/drupal-4.7.4/node/43#comment-3">bl and bu</a><br />11 weeks 6 days ago</li><li><a href="/drupal-4.7.4/node/43#comment-2">bu only</a><br />11 weeks 6 days ago</li><li><a href="/drupal-4.7.4/node/43#comment-1">bl only</a><br />11 weeks 6 days ago</li></ul></div></div>

 </div>

The blocks appear on screen but no sign of them being collapsible. I am working in Firefox and the js version is:

$Id: collapsiblock.js,v 1.1.2.5 2006/05/30 04:30:13 nedjo Exp

The only thing I can add is that the js console shows the following two errors:

Error: jsTools is not defined
Source File: http://localhost/drupal-4.7.4/modules/jstools/collapsiblock/collapsiblock.js
Line: 47

and this

Error: Error in parsing value for property 'cursor'.  Declaration dropped.
Source File: http://localhost/drupal-4.7.4/modules/jstools/collapsiblock/collapsiblock.css
Line: 8

It all seems a bit shaky at the moment - how safe is it to suppose that these things will work in users' browsers?

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

I'm trying to get this to work on 4.7.4 using standard Bluemarine theme

Do you have the jstools.module enabled? That's what defines the jsTools object.

joel_guesclin’s picture

joel_guesclin commented

Ok, that sorted it for me - thanks for the tip