Two patches for the next version of OG Panels module, open to test and feedback

this looks a lot like blueprints, which in retrospect I really probably should have ported to D6...it was silly to not provide that functionality in the immediate term just because I had a crazy long-term scheme to provide it more generally. So I'm glad to see development in this direction.

I do have to mention, though, that the naming is a problem. "Templates" is the first word that I considered using for blueprints, but ultimately rejected because the namespace has clearly been staked out by the theme system. I then used 'collections' for a while, but that didn't actually encompass the basic pattern very well. So I ultimately settled on 'blueprints.' Given that I'm gonna leave that project as just D5, and I really wanted it integrated into og_panels in the first place, though, if you want to use that namespace (and/or any of the code in there, though I now know it to be very primitive OO work), I'd be very +1 to that.

...and, if I ever do write that holy grail that is a fully abstracted blueprints system, we can integrate it then.

got some errors:

patching file og_panels.install
Hunk #3 FAILED at 105.
Hunk #4 succeeded at 209 with fuzz 2 (offset -21 lines).
1 out of 4 hunks FAILED -- saving rejects to file og_panels.install.rej

and

patching file og_panels.module
Hunk #11 FAILED at 1131.
1 out of 11 hunks FAILED -- saving rejects to file og_panels.module.rej

og-panels 6.x-2.0, OSX 10.6.3 (Snow Leopard).

I'm not positive but I probably did it with "patch -p0 <"

I'm getting

warning: call_user_func_array() [Function.Call-User-Func-Array]: First argument is expected to be a valid callback, 'og_panels_template_access' was given in .../.../includes/menu.inc on line 452.

errors.

Same errors when patching, I tried it with the Dev and with the regular release just in case.

Got these when updating:

user warning: Duplicate column name 'use_template' query: ALTER TABLE og_panels ADD COLUMN use_template int(11) NOT NULL DEFAULT 0 AFTER weight in .../.../sites/all/modules/og_panels/og_panels.install on line 198.
user warning: Duplicate column name 'template_did' query: ALTER TABLE og_panels ADD COLUMN template_did int(11) NOT NULL DEFAULT 0 AFTER use_template in .../.../sites/all/modules/og_panels/og_panels.install on line 199.
warning: Invalid argument supplied for foreach() in .../.../includes/database.mysql-common.inc on line 69.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') /*!40100 DEFAULT CHARACTER SET UTF8 */' at line 2 query: CREATE TABLE og_panels_templates ) /*!40100 DEFAULT CHARACTER SET UTF8 */ in .../.../includes/database.inc on line 550.

and

The following queries were executed
og_panels module
Update #6003
Failed: ALTER TABLE {og_panels} ADD COLUMN use_template int(11) NOT NULL DEFAULT 0 AFTER weight
Failed: ALTER TABLE {og_panels} ADD COLUMN template_did int(11) NOT NULL DEFAULT 0 AFTER use_template
Failed: CREATE TABLE {og_panels_templates} ) /*!40100 DEFAULT CHARACTER SET UTF8 */

I dropped those tables and updated to 6003 again:

warning: Invalid argument supplied for foreach() in .../.../includes/database.mysql-common.inc on line 69.

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') /*!40100 DEFAULT CHARACTER SET UTF8 */' at line 2 query: CREATE TABLE og_panels_templates ) /*!40100 DEFAULT CHARACTER SET UTF8 */ in .../../includes/database.inc on line 550.

and

The following queries were executed
og_panels module
Update #6003
ALTER TABLE {og_panels} ADD COLUMN use_template int(11) NOT NULL DEFAULT 0 AFTER weight
ALTER TABLE {og_panels} ADD COLUMN template_did int(11) NOT NULL DEFAULT 0 AFTER use_template
Failed: CREATE TABLE {og_panels_templates} ) /*!40100 DEFAULT CHARACTER SET UTF8 */

There's something wrong with the patches, that's what's causing it.

I dropped them like you said, and when I updated it put them back. I'll upload the patch rejects, maybe that will tell you something.

Related to the issue (the future of og_panels), but not to the patches -- #837064: Re-implement UI with custom changes (e.g. og_panels)

Installed 6.x-2.0
checked db - no tables exist for og_panels
downloaded patches
executed following for the first patch
>> patch -p0 < og_panels_next_version_install.patch
>> patching file og_panels.install
>> Hunk #3 FAILED at 105.
>> Hunk #4 succeeded at 209 with fuzz 2 (offset -21 lines).
>> 1 out of 4 hunks FAILED -- saving rejects to file og_panels.install.rej
executed second patch
>>patch -p0 < og_panels_next_version.patch
>>patching file og_panels.module
>>Hunk #11 FAILED at 1131.
>>1 out of 11 hunks FAILED -- saving rejects to file og_panels.module.rej
went to update database
6003 became available for og_panels
executed it
>> * warning: Invalid argument supplied for foreach() in /path_to/database.mysql-common.inc on line 78.
>> * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') /*!40100 DEFAULT CHARACTER SET utf8 */' at line 2 query: CREATE TABLE ogroups_og_panels_templates ) /*!40100 DEFAULT CHARACTER SET utf8 */ in /path_to/database.inc on line 551.

could you please possibly provide a zip file of working patched module for download?

Solution in pdf [comment #20] tells how to create a variant with latest version 2.0 that will be set as default for og_panels http://drupal.org/node/553456

The issue should remain open. Is anyone successfully testing this?

FYI I believe hobgobbler was testing with PHP 5.3.

I can't remember for sure if I was using 5.3 but it's very possible. I didn't know there were problems with it until recently.

Update status

Update status