Cart links don't work with textfield attributes

I get this error too, and also believe that it was due to an incomplete patch on #560358: Cart links don't work with checkbox attributes or textfield attributes.

The code from approx line 654 in uc_attribute.module is as follows:

        // Only discrete options can affect the price of an item.
        if ($attribute->display && count($attribute->options)) {
          // There may be many selected options, or just one.
          foreach ((array)$selected as $oid) {
            if ($oid > 0) {
              $options[$index] = (array)$attribute->options[$oid];
              $options[$index]['attribute'] = $name;
              $index++;
            }
          }
        }
        else {
          // Handle textfield attributes.
          $options[$index] = array(
            'attribute' => $name,
            'aid' => $aid,
            'oid' => 0,
            'name' => $selected,
            'cost' => 0,
            'price' => 0,
            'weight' => 0,
          );
        }
        $index++;

Here the $selected variable is treated as an array unless the attribute is a textfield.

I believe the best way around this is to re-instate some of TR's original patch in cart_links to check for an array.

Here is a patch that works for me with textfield attributes.

This patch doesn't introduce any extra security concerns as far as I can see. The uc_attribute module should be sanitizing all input whether from the url or the textfield itself.

Hi

I had the same problem as described in this bug report.

I have tested the patch and it worked correctly on Drupal 6.17 and Ubercart 2.3

Br.
Rune Christensen

subscribing

thank you so much,

this patch solves the text attribute problem for me, going on 2 years old.
AND solves the latest update problem which broke the cart_links with numbers.

I've been using numbers only which caused additional limitations for me, now I can use text strings. Big time saver :-)))

I'm hoping this isn't a security problem though

Does not seem to be working in 2.4! I reworked the patch slightly and it seems to be working now. Please see attached for my version of the patch.

I can confirm that the patch in comment #10 does work with Ubercart 6.x-2.4.

Thanks!

I just reverted to my initial fix from http://drupal.org/node/560358#comment-2556314 . Committed the fix to both the 6.x and 7.x branches.