Ran into a bunch of warnings:

notice: Undefined property: stdClass::$description in /Users/amorton/Sites/hostmaster/modules/node/node.module on line 1499.
notice: Undefined property: stdClass::$description in /Users/amorton/Sites/hostmaster/modules/node/node.module on line 1499.
notice: Undefined property: stdClass::$description in /Users/amorton/Sites/hostmaster/modules/node/node.module on line 505.
notice: Undefined property: stdClass::$description in /Users/amorton/Sites/hostmaster/modules/node/node.module on line 505.
notice: Undefined variable: x in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/package/hosting_package.module on line 60.
notice: Trying to get property of non-object in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/hosting.features.inc on line 101.
notice: Undefined property: stdClass::$nid in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/db_server/hosting_db_server.module on line 172.
notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 239.
notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 216.
notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 222.
notice: Undefined property: stdClass::$name in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 219.
notice: Undefined property: stdClass::$new_user in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 245.
notice: Undefined property: stdClass::$ip_address in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/web_server/hosting_web_server.module on line 273.

Most are just trivial, just needing an empty() to fix. The name => client_name seems like an actual bug. There's a bunch more of these that I haven't had a chance to get to yet.

CommentFileSizeAuthor
#7 hosting_e-all.patch5.78 KBdrewish
#4 hosting_e-all.patch7.85 KBdrewish
#3 hosting_e-all.patch7.46 KBdrewish
#2 hosting_e-all.patch8.74 KBdrewish
hosting_e-all.patch6.9 KBdrewish

Comments

drewish’s picture

drewish commented

I should make it clear that the warnings listed are the ones fixed by that patch.

Some might also be addressed by #814368: PHP E_ALL fixes over in the Hostmaster queue.

drewish’s picture

drewish commented
StatusFileSize
new hosting_e-all.patch8.74 KB

This adds fixes for:

notice: Undefined variable: form in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/web_server/hosting_web_server.module on line 308.
notice: Undefined variable: output in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/hosting_help.inc on line 498.
notice: Undefined index: #suggestion in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/hosting_help.inc on line 509.
notice: Undefined index: configuration in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/hosting_help.inc on line 509.
notice: Undefined index: #title in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/hosting_help.inc on line 525.
drewish’s picture

drewish commented
Version: 6.x-0.3 » 6.x-0.4-alpha3
StatusFileSize
new hosting_e-all.patch7.46 KB

Here's what applies to HEAD.

drewish’s picture

drewish commented
StatusFileSize
new hosting_e-all.patch7.85 KB 
notice: Undefined index: hidden in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/task/hosting_task.module on line 13.
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

Hi there,

Thanks for the patches!

Aegir no longer uses Drupal.org's CVS for development, thus the code in CVS that these patches are made against, is deprecated.

Would you mind making patches against the code from our git repos?

http://git.aegirproject.org/?p=hostmaster.git;a=summary

(git clone git://git.aegirproject.org/hostmaster)

drewish’s picture

drewish commented

I'm happy to roll against the git repo but I think you should update the project page to make it clear that that's where the code is being developed.

drewish’s picture

drewish commented
Status: Needs work » Needs review
StatusFileSize
new hosting_e-all.patch5.78 KB

here you go.

anarcat’s picture

anarcat commented
Status: Needs review » Fixed

committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 98c18e6 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by anarcat: 
    #814356 by drewish - fix E_ALL warnings

  • Commit 98c18e6 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by anarcat: 
    #814356 by drewish - fix E_ALL warnings