Ran into a bunch of warnings:
notice: Undefined property: stdClass::$description in /Users/amorton/Sites/hostmaster/modules/node/node.module on line 1499.
notice: Undefined property: stdClass::$description in /Users/amorton/Sites/hostmaster/modules/node/node.module on line 1499.
notice: Undefined property: stdClass::$description in /Users/amorton/Sites/hostmaster/modules/node/node.module on line 505.
notice: Undefined property: stdClass::$description in /Users/amorton/Sites/hostmaster/modules/node/node.module on line 505.
notice: Undefined variable: x in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/package/hosting_package.module on line 60.
notice: Trying to get property of non-object in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/hosting.features.inc on line 101.
notice: Undefined property: stdClass::$nid in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/db_server/hosting_db_server.module on line 172.
notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 239.
notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 216.
notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 222.
notice: Undefined property: stdClass::$name in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 219.
notice: Undefined property: stdClass::$new_user in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 245.
notice: Undefined property: stdClass::$ip_address in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/web_server/hosting_web_server.module on line 273.
Most are just trivial, just needing an empty() to fix. The name => client_name seems like an actual bug. There's a bunch more of these that I haven't had a chance to get to yet.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | hosting_e-all.patch | 5.78 KB | drewish |
| #4 | hosting_e-all.patch | 7.85 KB | drewish |
| #3 | hosting_e-all.patch | 7.46 KB | drewish |
| #2 | hosting_e-all.patch | 8.74 KB | drewish |
| hosting_e-all.patch | 6.9 KB | drewish |
Comments
Comment #1
drewish commentedI should make it clear that the warnings listed are the ones fixed by that patch.
Some might also be addressed by #814368: PHP E_ALL fixes over in the Hostmaster queue.
Comment #2
drewish commentedThis adds fixes for:
Comment #3
drewish commentedHere's what applies to HEAD.
Comment #4
drewish commentedComment #5
Anonymous (not verified) commentedHi there,
Thanks for the patches!
Aegir no longer uses Drupal.org's CVS for development, thus the code in CVS that these patches are made against, is deprecated.
Would you mind making patches against the code from our git repos?
http://git.aegirproject.org/?p=hostmaster.git;a=summary
(git clone git://git.aegirproject.org/hostmaster)
Comment #6
drewish commentedI'm happy to roll against the git repo but I think you should update the project page to make it clear that that's where the code is being developed.
Comment #7
drewish commentedhere you go.
Comment #8
anarcat commentedcommitted, thanks!