While working on #814356: PHP E_ALL fixes I found some small changes that we should make to the profile to fix the following warnings:

notice: Undefined property: stdClass::$config_path in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/web_server/hosting_web_server.module on line 311.
notice: Undefined property: stdClass::$backup_path in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/web_server/hosting_web_server.module on line 311.
notice: Undefined property: stdClass::$restart_cmd in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/web_server/hosting_web_server.module on line 311.
notice: Undefined property: stdClass::$drush_path in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/web_server/hosting_web_server.module on line 311.
CommentFileSizeAuthor
#6 hostmaster_e-all.patch2.28 KBdrewish
#3 hostmaster_e-all.patch1.73 KBdrewish
#2 hostmaster_e-all.patch1.73 KBdrewish
hostmaster_e-all.patch1.01 KBdrewish

Comments

drewish’s picture

drewish commented

It also helps with:

notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 239.
notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 216.
notice: Undefined property: stdClass::$organization in /Users/amorton/Sites/hostmaster/sites/all/modules/hosting/client/hosting_client.module on line 222.
drewish’s picture

drewish commented
StatusFileSize
new hostmaster_e-all.patch1.73 KB

This adds fixes for:

notice: Undefined index: #validate in /Users/amorton/Sites/hostmaster/profiles/hostmaster/hostmaster.profile on line 179.
notice: Undefined index: #node in /Users/amorton/Sites/hostmaster/profiles/hostmaster/hostmaster.profile on line 184.
notice: Undefined index: #submit in /Users/amorton/Sites/hostmaster/profiles/hostmaster/hostmaster.profile on line 188.
drewish’s picture

drewish commented
Version: 6.x-0.3 » 6.x-0.4-alpha3
StatusFileSize
new hostmaster_e-all.patch1.73 KB

Here's what applies to HEAD.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

Hi there,

Thanks for the patches!

Aegir no longer uses Drupal.org's CVS for development, thus the code in CVS that these patches are made against, is deprecated.

Would you mind making patches against the code from our git repos?

http://git.aegirproject.org/?p=hostmaster.git;a=summary

(git clone git://git.aegirproject.org/hostmaster)

drewish’s picture

drewish commented

I'm happy to roll against the git repo but I think you should update the project page to make it clear that that's where the code is being developed.

drewish’s picture

drewish commented
Status: Needs work » Needs review
StatusFileSize
new hostmaster_e-all.patch2.28 KB

here you go.

Anonymous’s picture

Anonymous (not verified) commented

Thanks very much!

I've also updated our project pages to make it more obvious that our CVS repos are deprecated.

anarcat’s picture

anarcat commented
Status: Needs review » Fixed

fix committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 63fd574 on dev-dns, dev-features, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newsiteform, dev-nginx, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-ssl, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat: 
    #814368 by drewish - fix E_ALL warnings

  • Commit 63fd574 on dev-dns, dev-features, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newsiteform, dev-nginx, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-ssl, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat: 
    #814368 by drewish - fix E_ALL warnings