Looking through features.module, most other functions that implement hook_features_export_render only take two arguments.
I can't wrap my head around exactly what $features_export does, but making it an optional parameter gets rid of the error...
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | rules_814416.patch | 777 bytes | tim.plunkett |
| #9 | rules_814416b.patch | 925 bytes | drnugent |
| #3 | rules_814416.patch | 771 bytes | tim.plunkett |
| #1 | rules_814416.patch | 525 bytes | tim.plunkett |
Comments
Comment #1
tim.plunkettIs this really all it is? Someone who understands the purpose of $features_export, please verify.
Comment #3
tim.plunkettWhoops, svn diff != cvs diff. Trying again.
Comment #4
tim.plunkettComment #5
fagohm, what is it why has it gone away? Maybe the feature API changed? Also probably the default should be more an array? If it's not necessary anymore at all, we can remove the parameter (php is fine if you call it with more parameters).
Comment #6
tim.plunkettTwo months ago the function was changed from
rules_features_export_rendertorules_categories_features_export_render. Features doesn't seem to have had any API changes relating to hook_features_export_render().Also, you're completely correct about the default being an array, not a string.
$features_export seems to be in there solely for exporting "rule_sets". Not sure what that's about.
Comment #7
mstef commentedThis was my take at it, as I've written Features integration before.
http://drupal.org/files/issues/rules.export.fixFeatures.patch
I haven't look at comment #3. I don't think my patch will apply cleanly to CVS.
Comment #8
drnugent commentedChanged default value to array. The latest beta of Features still has code that can pass a third parameter so I'm guessing it's best to leave this in and set a default.
Comment #9
drnugent commentedLooks like my patch got eaten last time.
Comment #11
tim.plunkettBad patch format.
Comment #12
drnugent commentedThanks Tim
Comment #13
fagoThanks, indeed features doesn't have such a parameter (any more) and rules doesn't it any more either, so I totally removed that parameter.
Comment #15
Josh Benner commentedRemoving the 3rd parameter is not technically correct. The hook documentation from the features API file:
Comment #16
tim.plunkettThe third parameter was re-added a month ago, it seems. After we fixed the issue the first time.
Comment #17
fagoComment #18
mitchell commentedMoving to "Provided Module Integrations" component.