I'm reviewing this module for use, and reading the code I found that it's not at all close to coding standards (http://drupal.org/coding-standards). As a first step, could you convert all the tabs to 2 spaces? Right now it's mixed, like the function splash_help() uses spaces, but just about everywhere else is tabs.

As another minor point, could you remove the ?> at the end of the file?

Comments

mail@victorquinn.com’s picture

Status: Active » Closed (fixed)

Fixed in a miscellaneous code cleanup commit: http://drupalcode.org/project/splash.git/commit/7e85c28