Closed (fixed)
Project:
@font-your-face
Version:
6.x-2.x-dev
Component:
Code (general)
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Jun 2010 at 18:11 UTC
Updated:
15 Apr 2012 at 19:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
sreynen commentedNot planning on adding any new providers until after 2.0.
Comment #2
rrutter commentedFontdeck will be providing an API by the end of 2010. Details will be available on http://fontdeck.com/support/
Comment #3
sreynen commentedAwesome, thanks.
Comment #4
sreynen commented@rrutter sent me the new API details. It looks like this should be pretty simple to implement. No preview, so it will work much like Typekit, where you enter your key on the settings page and only see the fonts within your Fontdeck account.
Comment #5
sreynen commentedFontdeck is committed to dev.
Comment #6
sreynen commentedJust realized this still needs to be ported back to D6.
Comment #7
sreynen commentedComment #8
thomasmuirhead commentedHi there,
It'd be great to see fontdeck added to the drupal 6 version. Is this easy to do? Where would I start?
Thanks
Thomas
Comment #9
sreynen commentedIf you're familiar with writing Drupal 6 modules, it should be pretty easy to port. All of the logic is already written, so someone just needs to change the specific code where it's D7-specific. Most of the code should work fine in D6, so there won't be much to change. The relative ease of this is one reason I haven't done it myself; I'm hoping others might use it as a starting point to get involved in development.
My general approach would be to copy the D7 version, change the version in the .info file, enable it in D6, and then fix whatever breaks.
Comment #10
feng-shui commentedAttached is my initial pass at a D6 FontDeck module, may need some more work as I continue to use it, but should get people started. Attached as a zipped module rather than a patch - apologies Git is giving me some issues this morning would be great it someone could roll a patch from it.
Comment #11
sreynen commentedThanks for the port! I'll try to review this soon.
Comment #12
mdeltito commentedJust a note:
The fontdeck backport posted by Feng-Shui in #10 works fine for me. There were only 2 changes that were made (compared to the fontdeck module in current dev)
One issue I had was with line 29:
The leading '/' before 'project-info' causes the request to fail, at least for me. Removing that slash fixes the $project_info_url having double slashes, and now everything works as expected.
Attached is a patch against dev
Comment #13
sreynen commentedThis is committed. Thanks everyone!