Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The replacement of the module_exist function with module_exists has made the PayPal Pro module incompatible with Drupal 4.7 again. After all the work on 4.7 compatibility, this is a real let-down. Can this module be committed to the 4.7 branch with a warning that we are still working on it?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | paypalpro.module_5.patch | 364 bytes | darren oh |
Comments
Comment #1
darren ohComment #2
darren ohWe need a 4.7 branch to develop separately from HEAD, but I don't have authority to create this. Gordon is concerned about compliance with PayPal's policies. I have created issue 81127 to deal with this concern. This patch adds a warning to the modules page that this module is for development only. I'm hoping this will be enough to get a 4.7 branch authorized. When the new system for releasing Drupal contributions is implemented, we should no longer have to worry about unstable code in the branches.
Comment #3
gordon commentedI cannot tag the paypalpro module without having it included in the ecommerce archive.
All fixes must be applied to HEAD, and then once paypal pro is in an acceptable state I will backport it to 4.7
Comment #4
darren ohComment #5
darren ohDevelopers who need to test on Drupal 4.7.x can replace paypalpro.module with revision 1.14 from CVS.
Comment #6
Tresler commentedAm I correct in thinking that we now have the ability to tag a 4.7 branch and not have it put in a daily build? If so, could we do so - perhaps from the last known workable version? I'd love to attempt to put some time into making this compliant for paypal ToS and working for drupal 4.7 - but in truth am having difficulty trying to figure out which version I should be using...
Comment #7
gordon commentedATM the Paypal Pro module is no where near ready for release. Even for 5.0. The current version sort of works but doesn't comply with the Terms and conditions of Paypal.
I would consider tagging this but it doesn't even come close to be releasable.
There is a lot of work that needs to be done and At this stage no one is willing to do the work, or even sponsor the work being done to build a version of the Paypal Pro module for EC 5.0.
Once it has been built for 5.0 we can look at back porting this to 4.7. At this stage I see no version of Paypal Pro for 4.7, and I don't see it likely having a version for release with 5.0.
Comment #8
Tresler commentedWell, my point is that I have a client I'm working with now who needs it for 4.7 - hence I need to bring it up to speed for 4.7 - but without it tagged I don't know which version to start with. Are you suggesting I should bring it up to 5.0 and do the backport, cause I'm not sure I'm up for *that* much work? Point me in the proper direction and I'd be happy to at least get an analysis of what needs to be done to make it work on 4.7 and make it Paypal compliant.
It is entirey possible that I'll take one look at it and decide we need to find another solution for a gateway (suggestions are welcome) - but I'd at least like to know where to look to make that decision.
Comment #9
darren ohTresler, the new release system is not implemented yet. The latest revision for 4.7 is 1.14. The only work in subsequent revisions was for 5.0 compatibility. Issue 81127 summarizes the ways in which our current implementation violates PayPals terms and conditions.
Comment #10
simehousekeeping
Comment #11
darren ohNow that the new release system is available, this can be fixed.
Comment #12
gordon commentedUntil someone wants to take control, and fix all the bugs I do not see this being done.
If someone wants to submit patches to get this working, and comply with the t&c and work nicely with EC then I will include it.
Comment #13
darren ohI did not ask you to do anything but follow current Drupal standards by having a HEAD for each version of Drupal. You are discouraging contributions by not doing so.
Comment #14
brmassa commented