This is a request to reverse #605816: No warning for incorrect payment set up with PayPal for the following two reasons:

  1. The warning message never appeared, because the variable name was misspelled in _uc_coupon_paypal_check() (the correct variable name is uc_paypal_wps_submit_method instead of uc_paypal_wbs_submit_method).
  2. Once #815482: PayPal Website Payments Standard: Convert negative line items to discounts is committed, PayPal will receive discount information which means that submission of the entire order as a single line item will no longer be necessary.

The attached patch makes the necessary changes.

CommentFileSizeAuthor
remove_itemized_warning.patch1.47 KBguypaddock

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Postponed

#1 is present in 6.x-1.3 but has been fixed in the -dev branch in the commit for #605816: No warning for incorrect payment set up with PayPal

For #2, that patch is only in the Ubercart dev branch so far, marking this postponed until a new Ubercart release is out that includes this change.

jtsnow’s picture

jtsnow commented
Status: Postponed » Reviewed & tested by the community

Payments with PayPal Website Payments Pro and coupons now work for me when the order is itemized. The patch correctly removes the warning message.

wodenx’s picture

wodenx commented
Status: Reviewed & tested by the community » Fixed

Thanks. Committed to DEV.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tescometro’s picture

tescometro commented

Ok, So I've just got this "warning" with Ubercart 2.6 and Ubercart Discount Coupons 1.7 Does the above mean I can just ignore the warning, or is there still a problem with itemized items?

(am using paypal standard payments)

P.S. thanks for this module, besides the "warning " issue, it seems very sensibly configured and designed, and works pretty much exactly as expected.