Closed (fixed)
Project:
Comment driven
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
3 Jun 2010 at 09:37 UTC
Updated:
18 Jun 2010 at 14:00 UTC
In the comment form, this module changes all the field names by adding driven before it.
I don't see a good reason?
I know this interferes with other modules, like Live for instance.
Comments
Comment #1
arhak commentedlets start with the project page's description
what this module does is taking a node_form + comment_form and build a merged form to handle both at the same time
then issues arise, like:
- node_form having a 'comment' property to indicate whether "Comment settings" on that node are "Disabled", "Read only" or "Read/Write" (with respective values of 0,1,2) while the comment_form has a 'comment' property which represent the comment's body
- similarly, node_form may have other properties with the same names of comment_form's properties ("name clashes"), and when 3rd party modules comes in it gets worse
this is documented in the code, where
comment_driven_form_altertakes place,check
comment_driven.alter.incnear line 80:this is just right before invoking
_comment_driven_disguise_childrenthe trade-off, as mentioned above, is that some comment-related modules might brake,
some of them can be handled making this module aware
other modules might not be compatible at all (e.g. comment_bonus_api)
some might need to be aware each other (e.g. WYSIWYG #747616-2: Compatibility with WYSIWYG)
and luckily, some will be seamlessly compatible (e.g. notifications_team, after bibo's contribution)
the worst part being modules which are capable of handling nodes and comments (e.g. comment_upload, WYSIWYG, notifications, live) because they are prepared to make their tweaks on either a node_form or a comment_form but not to a form which is both at the same time,
therefore, a solution might exists, but depends on what the 3rd party module does (e.g. notifications is been the wiser so far, and comment_upload the nastier)
Comment #2
arhak commentedregarding the "live" module, it states in its project page:
cdriven certainly requires a "complex validation", since it acts on behalf of a node submission and a comment submission at the same time
if you want you can open an issue for "Compatibility with Live", I would check it then, but with that description and AJAX involved it is unlikely to be compatible
check what cdriven does on preview, and you'll notice that there is both a node preview and a comment preview at the same time (which even has exposed core's bugs on preview #716788 and other 3rd party modules' bugs #718824: follow up foreign issues)
it seems to me (without making any review) that "live" wouldn't handle so complex forms
Comment #3
arhak commentedComment #4
ManyNancy commentedThank you for your work in improving the whole ecosystem.
I wasn't so ambitious as to want to use Live with cdriven diffs, but merely just the stuff in the comment. Doing some minor hacks on Live was enough to make it work. This thread is just an inquiry.
Comment #5
arhak commented