This module relies on field_extra_field_weight to function (line 1218 of webform.module), but this is removed from drupal HEAD.

Marked as critical because this prevents the webform node from being shown (white screen) and thus renders the module useless with the latest drupal dev version.

CommentFileSizeAuthor
#4 webform_field_extra_weight.patch764 bytesquicksketch
#1 817094-webform-removed-field-function.patch1.15 KBStevel

Comments

Stevel’s picture

Stevel commented
StatusFileSize
new 817094-webform-removed-field-function.patch1.15 KB

This patch seems to solve the issue, though I'm not sure the semantics are correct.

Stevel’s picture

Stevel commented
Status: Active » Needs review
quicksketch’s picture

quicksketch
he/him
commented

Thanks Stevel, I think we might be able to remove the dynamic weight entirely and just set it to 10 or something. The function http://api.lullabot.com/_field_extra_fields_pre_render/7 should fix the problem for us no?

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed
StatusFileSize
new webform_field_extra_weight.patch764 bytes

Hmm, currently HEAD seems pretty broken. I can't find where "extra" field settings show up at all. I've got both Webform and Comments enabled on a content type but neither of them show up under the "Manage Display" tab.

The comment_node_page_additions() function doesn't seem to set a weight *at all*, which I believe indicates that Field module should set the weight for it. Unfortunately since you can't change the weight through the UI, it's a bit hard to test.

For the time being I'm just going to set the weight to 10 and assume that Field module will eventually start working again. To prevent bug reports saying Webform's weights don't work in Alpha 5, we'll use a conditional for the next few months until D7 stabilizes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.