While having support for title and description is good in general, in some cases it is better to keep it simple. In my case for example, I want to show only images in my gallery. So complying to the requirements of the module means I have to add two artificial fields to the view and then hide them by editing the CSS.

It would be better to have a configuration option that controls that or even simpler: make the title and description optional and don't generate code for them if a corresponding field is not selected.

Thanks!

Comments

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

I think that would be a really useful feature. +1

So far, in order to achieve this, I hack the views-galleriffic-view.tpl file and comment the 'caption' line out. Like so:

  <div id="gallery" class="content">
    <div id="controls" class="controls"></div>
    <div id="loading" class="loader"></div>
    <div id="slideshow" class="slideshow"></div>
    <!-- <div id="caption" class="embox"></div> -->
  </div>

...nasty workaround, I know (has to be applied each time I upgrade to a new version of VG).

kirilius’s picture

kirilius commented

That's exactly my point. A little more flexibility will save a lot of work on the long run.

acouch’s picture

acouch commented
Version: 6.x-6.x-dev » 6.x-1.x-dev
Status: Active » Postponed

I see why this would be useful. Thank you for reporting it. For now I am not going to implement this. I will try and do this for the D7 version.

kirilius’s picture

kirilius commented

Thank you!

mrgoltra’s picture

mrgoltra commented

subscribing.

acouch’s picture

acouch commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

I made updates for the 7.x version. Didn't yet get a chance to add this though. Will do so next time I sit down and work on this.

nasi’s picture

nasi commented

Subscribing and +1

dirtysteak’s picture

dirtysteak commented

+1

HaloFX’s picture

HaloFX commented

+1

TimeBandit’s picture

TimeBandit commented

Maybe this should be a separate comment but that tpl file could be updated as well. Its invalid HTML to use an ID name that is the same as a CLASS name. So, for example, this is invalid HTML:

<div id="slideshow" class="slideshow"></div>

Also, it may be best to make the the ID and CLASS something less likely to collide with other CSS -- "slideshow", "gallery", "controls", etc. are all fairly likely CSS ID/CLASS names to be used by other modules, etc. Maybe use ID and CLASS like...

<div id="gallerific_slideshow" class="gallerific_slideshow_type1"></div>
klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented

+1 for what John says in #10. We should avoid using generic names for variables/IDs/classes etc. This should be a general practice (something like the drupal coding standards) in all contrib modules/themes and generic names should be reserved for core.

acouch’s picture

acouch commented

I'll get to this within the next couple of weeks.

acouch’s picture

acouch commented
Status: Postponed » Fixed

I've implemented this along with the suggestion in #10

AndrewS’s picture

AndrewS commented

Heya,

Apologies - but did this make it to the 2011-Aug-08 dev release?

Can't seem to locate this feature.

Cheers,
A

acouch’s picture

acouch commented

This is in the latest dev release as well as the new 1.0 release.

When selecting the "Galleriffic Fields" you'l notice Title and Description are optional.

kirilius’s picture

kirilius commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.