Wow, this module looks great! So you should make it translatable asap. At the moment, there's no translation catalogue, and strings aren't extractable via potx. Furthermore, the strings in template files are wrapped with t(), but not in the main module.

Keep on rockin' !

Regards,
Boris

Comments

blainelang’s picture

blainelang commented

Thank you for your review comments.

What do you mean the language in the module is not using t() - give me some examples as I definitely am using the Drupal methods.

drubb’s picture

drubb
he/him
Primary language German
Location Sindelfingen
commented
Status: Active » Fixed

At the moment I can't reproduce this any more. Perhaps it was too late in the night...

I've now downloaded the latest dev-version again, and you're right, the strings in the .module file are all wrapped in t(), and suddenly potx finds the module and extracts translation templates.

Perhaps my previous version was an early one, or maybe I've confused two modules, don't know. Sorry for any inconvenience.

Regards,
Boris

blainelang’s picture

blainelang commented

Not a problem and very pleased that someone is trying out the translation features. I am not sure if the strings in the javascript have been hooked correctly for translation but I have used the drupal.t() function and isolated all the language in filedepotlanguage.js

Can you verify if this has been done correctly?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.