Posted by patrickharris on June 4, 2010 at 3:30am
11 followers
Jump to:
| Project: | Omega |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | himerus |
| Status: | needs work |
Issue Summary
At the moment the width of sidebars is subtracted from the width of content, even if sidebars aren't being displayed. It would be great to be able to allow the main content to take up 100% width if sidebars are absent.
Comments
#1
I will verify this, but can you send me screenshots of the settings in your theme settings page for content zone, and also a screen of the site without sidebars where the content is NOT full width?
By default, it "should" take the full container width for the content zone, and actually "ignore" the selected item for the content zone, so if neither sidebar is present, it should be taking the full width...
If this is failing, it's a bug, and not a feature request, so I'll update the ticket accordingly, and do some testing on my localhost tomorrow on trying to replicate.
#2
Okay, I do see the issue here... replicated it in my sandbox...
Definitely a bug... will get fixed asap!!
Marking critical as well... this really IS quite important in the way the grid and usage of the ns() function should be working.
#3
I found the error in template.php under _omega_dynamic_widths
<?phpfunction _omega_dynamic_widths($width, $conditions, $vars) {
foreach($conditions AS $variable => $zone) {
if((isset($vars['page'][$variable]))) {
$width = $width - $zone['width'];
}
}
return $width;
}
?>
changed to:
<?phpfunction _omega_dynamic_widths($width, $conditions, $vars) {
foreach($conditions AS $variable => $zone) {
if((isset($vars['page'][$variable])) && count($vars['page'][$variable]) > 0) {
$width = $width - $zone['width'];
}
}
return $width;
}
?>
Change committed and fixed in Alpha8 release.
#4
Thanks!
#5
Marking back as fixed.
Let me know if there are any further issues with this. I plan to release the first Beta version for D7 this weekend. Most everything seems ironed out, and ready to put in production on D7.
#6
Automatically closed -- issue fixed for 2 weeks with no activity.
#7
Erm - seems like I'm having the same issue as described above with 7.x-3.0
My fault? Anyone else?
#8
This is only occurring in 7.x-3.0 if debug mode is on. Log another issue.
#9
This is still an issue... I wouldn't have found the solution if it hadn't been for this post... was another issue opened in the end? Be worth getting this fixed if possible
#10
In 7.x-3.1 the bug persist.
#11
This is occurring if debug mode is off too.#12
This is occurring if debug mode is off too.#13
I am having the same issue here. Debug is off.Found the problem. I need to set content region as main region in content zone, then it will scale to full width.
#14
I am still having a problem with this.
I'm not sure how to
'set content region as main region in content zone' as mentioned in the previous post.