_imceimage_image_to_filepath() stinks. (Space in image filename causes error on save)

Try this

I've tested this fix, works like a charm. Thanks Kelvin.

thanks !

Is this still an issue in the 6.x-2.x branch?

$_SERVER['DOCUMENT_ROOT'] is not a safe value to use. If someone runs Drupal in apache with mod_vhost_alias, this variable contains nonsense data. Instead, use the return value from cwd() which is always the Drupal site root.

Ok, I agree this _imceimage_image_to_filepath() stinks.
There is another issue where we discuss the same (or closely related) problem.
#697174-20: imceimage.module produces invalid HTML (non-unique id attributes) in Lists and Front Page
but there it is totally off-topic.

So, let's have this as the major issue where we discuss the $url to $filepath conversion stuff.
A lot has happened on git recently, please have a look at the latest posts in the linked issue.

I'm not sure about the solution to this, but spaces should never be allowed in a filename anyway in proper HTML syntax.

Spaces are allowed in filenames, it's just that in URLs they should be properly encoded as %20.

What appears to be my problem is that files get stored in the database with an absolute path starting with a / and with special characters being encoded, ie: /sites/default/files/test one.png is stored as /sites/default/files/test%20one.png

On display, that gets encoded *again* the passed to theme('imagecache') so I end up with imagecache trying to display a file called /sites/sites/default/files/preset/sites/default/files/test%2520one.png, which of course fails quite badly.

I can make all problems go away by removing the starting / from entries in the database and un-encoding the special characters.

My more automagic workaround is to fix the filepath in hook_field($op = 'validate', ...) an to add hook_field($op = 'sanitize', ...). In both, I run the field values though this helper:

/**
 * Helper to make imceimage URls relative and not escaped.
 */
function _imceimage_fix_filepath($url) {
  if (strpos($url, '/') === 0) {
    $url = substr($url, 1);
  }
  return rawurldecode($url);
}

That seems to do the trick. I should probably mention that this was not an issue in Drupal 6.16, but became a problem overnight when I upgraded the site to Drupal 6.25.

Hmmm... I like cafuego's solution to just strip down whatever kind of URL is found in the database and make it relative...

I recently had to patch this module and found that the _imceimage_fix_filepath() function worked just fine when I replaced it with cafuego's code in #9:

function _imceimage_image_to_filepath($url) {
  if (strpos($url, '/') === 0) {
    $url = substr($url, 1);
  }
  $url = rawurldecode($url);
  return $url;
}

Maybe I'm missing something obvious about what this function is used for, but it seems as though $url is always going to be relative to the Drupal root, and by stripping off the leading slash and decoding the URL, we get a valid file path.

I'm attaching a patch just to help things along. Hope this helps!