I am wondering if there is some configuration I am missing or if this should be a feature request. I have a site that is running this module and I have noticed something that I think should be addressed. If you have multiple displays in a view and the header or footer is overridden on those displays, shouldn't the different over rides be shown in the editor?

Thoughts?

CommentFileSizeAuthor
#4 views_ui_basic-user_instructions-821064.patch1.15 KBaaronbauman

Comments

mstrelan’s picture

mstrelan commented

Subscribe. I think if you edit text for a display it should set it to Override by default. If you wanted to override the default text then you should edit the default display.

Jonah Ellison’s picture

Jonah Ellison commented
Assigned: Unassigned » Jonah Ellison
Status: Active » Closed (fixed)

I've changed the functionality in the 6.x-1.2 release to override by default. This should make setup and editing less confusing.

les lim’s picture

les lim
he/they
Primary language English
commented
Version: 6.x-1.1 » 7.x-1.x-dev
Component: Code » Documentation
Assigned: Jonah Ellison » Unassigned
Category: feature » task
Status: Closed (fixed) » Needs work

The following help text in views_ui_basic_admin_form() still reflects the old behavior:

$form["#prefix"] = '<p>' . t('Use this form to define which Views may be editable by users with the "' . l('edit views basic settings', 'admin/user/permissions').'" permission.') . '</p><p>' . t('Please note that the  "override" button will be hidden, so if your view uses multiple displays, you will probably want to modify the header/footer/empty text/title/etc fields to be "overriden," otherwise it will update the default display when the user goes in and modifies them.'). '</p>';
aaronbauman’s picture

aaronbauman
he/him
commented
Title: Ability to Edit Overrides » Update user instructions to reflect "auto-override" behavior
Status: Needs work » Needs review
StatusFileSize
new views_ui_basic-user_instructions-821064.patch1.15 KB

The same issue exists for 6.x

Here is a patch rolled against 6.x (which might apply to 7.x as well, with some fuzz -- haven't tested)

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Needs review » Needs work

On a related note, using the l() function inside of t() like that makes the string untranslatable. String replacement should be used instead.

  • Commit 1cbea51 on 7.x-1.x by Simon Georges: 
    Issue #821064: Update user instructions to reflect 'auto-override'...
simon georges’s picture

simon georges commented
Issue summary: View changes
Status: Needs work » Fixed

Fixed (as well as the link issue in t() call).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.