warning: Parameter 2 to ad_flash_adapi() expected to be a reference (php 5.3 compatibility)

That would remove the error messages, but I'm not sure it's the whole solution, since ad_flash_adapi() seems to expect to be able to alter the passed $node object:

unset($node->files);

The _adapi hook gets invoked in ad.module:

module_invoke("ad_{$node->adtype}", adapi, $op, $node);

module_invoke() doesn't support arguments as references, which makes ad_flash_adapi()'s changes to $node futile if I understand correctly. The error messages introduced in php 5.3 only puts the finger on an existing problem. So with that in mind, the change suggested by kobee shouldn't introduce any new problems.

Question is, can ad_flash_adapi() do without altering the $node object? I think that's a question for the module author. If not, ad.module has to be modified to invoke this hook in a way that supports references, similar to how node_invoke_nodeapi() does it.

Thanks for the solution. It's been awhile since i haven't updated this module. I'm looking to do a cummulative update this month tough.
Thanks again.

i changed line 211
function ad_flash_adapi($op, &$node) {
to
function ad_flash_adapi($op, $node) {
error disappear, is this correct fix of this issue ?

That fixes it for me. $node is an object, and objects are (effectively) passed by reference. Patch attached that accomplishes #3.

Check http://php.net/manual/en/language.oop5.references.php

Works for me.

The hook ad_flash_adapi is sometimes its called directly, where a reference may be ok, but sometimes with module_invoke which can't pass arguments by reference.

See also drupal API module_invoke.

Looking on all other implementations of hook_adapi the arguments never will be passed by reference, so it shouldn't be done here neither.

Closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.