In developing Acidfree for Drupal 5.0, I decided to use the Video and Image modules rather than define custom Acidfree node types. While this is a major rewrite and lots of work for me, I think it is good for the community at large. In doing so, I found that the Video module was not quite up to date with HEAD (with reason since HEAD has been changing daily). But here is the patch that I have come up with to simply update it.

In reviewing it, there may be some things that I cut out that I shouldn't have, but I wasn't sure how to deal with them. hook_link has changed so it is more like the primary_links, which rather than just returning a html string with links, it returns an array of arrays that have href, title, attributes, etc. So hook_links was heavily modified. I think most of the other stuff is fairly straight forward if you read the updating from 4.7 to HEAD guide.

CommentFileSizeAuthor
#11 video_updates_to_head.patch_3.txt14.04 KBvhmauery
#9 video_updates_to_head.patch_2.txt12.96 KBvhmauery
#5 video_updates_to_head.patch_1.txt13.64 KBvhmauery
#2 video_updates_to_head.patch_0.txt14.66 KBvhmauery
video_updates_to_head.patch.txt6.87 KBvhmauery

Comments

vhmauery’s picture

vhmauery commented

I just realized that there are still some things missing here... I forgot to update all the plugin modules and also to add the .info files for each module. I will try to get a patch for that soon. :)

vhmauery’s picture

vhmauery commented
StatusFileSize
new video_updates_to_head.patch_0.txt14.66 KB

Okay, here is a more updated patch. It includes all the .info files needed for HEAD. I haven't actually tested all the files, but you get the idea.

eagereyes’s picture

eagereyes commented

Hi, not trying to hijack your thread, but I'd be very interested in what changes you are planning for the 5.0 version of acidfree. I think image handling is really the one weak point of Drupal, and acidfree is a great step in the right direction - but a few more things could be done. Also, including lightbox to work with acidfree would be excellent. So if you have any pointers to webpages etc., I'd be interested.

vhmauery’s picture

vhmauery commented

eagereyes,
I wrote up a page on what I am planning to do at http://drupal.org/node/82267 and welcome comments. As for lightbox, if it works with Image module, it should work with the new Acidfree.

vhmauery’s picture

vhmauery commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new video_updates_to_head.patch_1.txt13.64 KB

Ok, I guess I did something stupid on my last rev because it didn't seem to apply to CVS. I just updated and got a clean checkout of CVS and applied this patch and it worked for me. This patch is probably the most important (from my standpoint) of all the patches I am pushing at Video. This patch brings Video and all the plugins up to date with Drupal HEAD. All my other patches depend on this patch (and as such will not apply until this one has been applied.)

Please apply.

fax8’s picture

fax8 commented
Status: Reviewed & tested by the community » Needs work

I finally branched with DRUPAL-4.7 the current video module version.
This means that for now on we will work for the next drupal 5.0 .

I tryed this patch. These are my first impressions:

configuration links: you used capitalized links in administration menu items (Video customfields settings, Video settings) while the all other links are lowercase. please change to lowercase.

configuration links location: you put video module configuration under site configuration.
In the conversion guide:

admin/content -- for content related activities; modules that create a node type should put their administrative items here.

then IMHO we should use admin/content not admin/settings

configuration links grouping: I would like if video related modules could create a grouping (like at admin/settings) defining the default place to find video modules. When a user go to admin/content/video a page listing all video_* modules is displayed and then he can choose the plugin to configure eg admin/content/video/multidownload

video type description: There is no description at "admin/content/types" for video node type.

I continue trying this patch. I will report here something else.

fax8’s picture

fax8 commented

Video_upload settings page seems broken:

warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'video_upload_admin_settings' was given in /home/fabio/web-related/CMS/drupal/cvs/drupal/includes/form.inc on line 181.

vhmauery’s picture

vhmauery commented

As per #6, I will try to reroll a patch that fixes those.

As per #7, hmmm. I think that may have been because I removed the video_upload settings page with the patch from http://drupal.org/node/82396

I guess I should fix it here and remove it with that one. I will fix that in the next rev too.

vhmauery’s picture

vhmauery commented
Status: Needs work » Needs review
StatusFileSize
new video_updates_to_head.patch_2.txt12.96 KB

Fabio,

Okay, here is a new patch with the items from comments 6 and 7 fixed. This also caused a change to the video types patch at http://drupal.org/node/82396

fax8’s picture

fax8 commented
Status: Needs review » Needs work

Vernon,

I think there are some problems with this patch...

    * video_customfields settings inaccessible: module needs updating because the _settings hook has been deprecated.
    * video_multidownload settings inaccessible: module needs updating because the _settings hook has been deprecated.
    * video_upload settings inaccessible: module needs updating because the _settings hook has been deprecated.
    * video settings inaccessible: module needs updating because the _settings hook has been deprecated.

Maybe you sent a old version?

Fabio

vhmauery’s picture

vhmauery commented
StatusFileSize
new video_updates_to_head.patch_3.txt14.04 KB

No, it wasn't an old version -- it worked just fine on my CVS drupal setup. Did you refresh the menu cache after you tried it? Anyway, those functions don't have to be called whatever_settings anyway, so I renamed them to whatever_settings_form. So now it should work for you. But make sure you refresh the menu cache (just hit 'Save configuration' on the admin/settings/module page).

So here is a new version. So there is also a new version of the video types patch like last time.

vhmauery’s picture

vhmauery commented
Status: Needs work » Needs review
fax8’s picture

fax8 commented
Status: Needs review » Fixed

Ok. Really a good work.

Committed to cvs. Thanks.

Fabio

fax8’s picture

fax8 commented

please note that I made little modification to menu links of plugins modules.
I simply called them as eg "upload" instead of "video upload settings" which
was redundant with the general "video settings" link.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)