Closed (won't fix)
Project:
Coder
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Jun 2010 at 00:34 UTC
Updated:
16 Jan 2016 at 18:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pillarsdotnet commentedPatch/fix:
Comment #2
pillarsdotnet commentedA related bug is that it demands parentheses after class names, which I'm told is incorrect.
Comment #3
sunIndeed. Here's a patch that confirms the bug.
Comment #4
pillarsdotnet commentedAlso see #1198452: @see references should each be on their own line.
Comment #5
sunoh, no testbot for Coder? Odd.
The intention of #3 obviously was to prove that expectations are failing (after adding them). But without testbot, that's kinda pointless ;)
So here's the merged and minimally fixed patch, but the change to the regex doesn't look correct to me. (EDIT: ...and fails tests)
Comment #6
tim.plunkettThe regex looks good. Patch still applies.
Comment #7
fgmNot sure whether this should be included in this patch version, but is also erroneously flags functions in namespaces. For instance this triggers the warning:
Since namespaces are fast becoming more common since D8 started and their inclusion in the coding standards (http://drupal.org/node/1353118), the patch should probably address them too.
Comment #8
megachrizMarked #1455950: @see MyClass::myMethod() is not allowed as a duplicate of this issue.
Comment #9
skwashd commentedThis patch doesn't apply anymore. Even after a reroll a lot of the tests fail.
Comment #10
klausiCoder 7.x-1.x is frozen now and will not receive any updates. Coder 8.x-2.x can be used to check code for any Drupal version, Coder 8.x-2.x also supports the phpcbf command to automatically fix conding standard errors. Please check if this issue is still relevant and reopen against that version if necessary.