Patch for porting for Drupal 5.0

Thank you for this patch.

I will wait for a while, since it is a bit to early to branch for 5.0.

First of all, here is the needed .info file.

Patch does definitely not work for me (drupal 5 RC1). I get a blank page after activating the module (however it never seems to activate so drupal keeps on working fine). I get the error:PHP Fatal error: Call to undefined function _feedback_add_page() in feedback.install on line 26, referer: http://localhost/admin/build/modules

I did what I could to figure out what's going on although I'm not into php so I did not get far...

Porting this module to v.5 urges as RC1 is out.

Phil

Patch does not apply cleanly.

Please roll a new patch.

Setting priority to normal.

Here's a re-rolled version of stefano73's patch against the current cvs.

Thanks

I committed this to HEAD, so the dev package for feedback should be created soon.

When someone tests that and confirms it is working, I will tag the module for 5.0, then we will have an official version.

The issue with the _feedback_add_page failing during a new install.
The fix: add require_once 'feedback.module';

Changes to the menu to make it more standard.
/**
* Implementation of hook_menu().
*/
function feedback_menu($may_cache) {
$items = array ();
if ($may_cache) {
$items[] = array (
'path' => 'feedback',
'title' => t('Feedback'),
'callback' => 'feedback_mail_page',
'access' => user_access('can send feedback'),
'type' => MENU_NORMAL_ITEM,
);

$items[] = array (
'path' => 'admin/settings/feedback',
'title' => t('Feedback'),
'description' => t('Configure the feedback page'),
'callback' => 'feedback_settings_page',
'access' => user_access('administer feedback'),
'type' => MENU_NORMAL_ITEM,
);
}
return $items;
}

Warren,

I included your changes for the menu. Committed to HEAD.

About the require_once(), I see your point. Do you think this should be a permanent part of the .install file?

If so, please make a patch.

Added fix for require_once.

Committed to HEAD and 5.x