When posting long sections of code, the geshifilter module will segfault the webserver fork/process in the call to preg_match_all(), at least on linux machines. The cause of seems to be a limitation in the PCRE library used to evaluate regular expressions (see http://bugs.php.net/bug.php?id=13618)

So this is not directly the responsibility of the geshifilter module, however, I think in this case a workaround would be appropriate, for example by simplifying the regex so it doesn't consume all the stack space anymore, or by splitting the tag matching process into multiple steps.

Comments

robloach’s picture

robloach
he/him
commented

I haven't experienced this yet.... If you take a look at DrupalBin's Panels.module, it's 1456 lines long and doesn't segfault.... That's on a Linux box.

soxofaan’s picture

soxofaan commented
Version: 6.x-1.x-dev » 4.7.x-1.x-dev
Priority: Normal » Minor
Status: Active » Postponed (maintainer needs more info)

I also think it's fairly reasonable to ignore this bug report, as long as we don't have more information on how to reproduce it.
It's an old bug report (sep 2006), for the 4.7 branch.
The 5.x-2.x branch of GeSHi filter uses a different way of regular expression handling with preg_replace_callback() instead of preg_match_all(), which is maybe less/not susceptible to the bug.

soxofaan’s picture

soxofaan commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

closing this issue because of lack of information and it's probably not valid anymore (see #2)