Themeswitcher module patch
agentrickard - September 4, 2006 - 16:21
| Project: | Drupal.org webmasters |
| Component: | web site |
| Category: | task |
| Priority: | normal |
| Assigned: | agentrickard |
| Status: | patch (code needs review) |
Description
As requested on the themes list, I have corrected some of the errors in the themeswitcher.module.
Attached is a patch vs. cvs. I will also attach the entire new file, just for simplicity.
| Attachment | Size |
|---|---|
| themeswitcher.patch | 4.68 KB |
#1
The new code has some substantial changes from prior (since my handling of arrays is more simplistic).
it may be easier, then, to just replace the whole file. Attached is the new module version.
#2
I went ahead and coded a themeswitcher_page function and menu element.
This gives an overview page that allows for theme selection.
This patch replaces the above.
#3
New module attached.
#4
Screenshot of themeswitcher_page callback.
#5
#6
Add a comment to become subscribed.
The code looks very nice, but I'd need to review it a bit closer (and test it! ) :)
#7
There's at least one error. In themeswitcher_get_current() line 297, I need to invoke global $user as well.
- global $custom_theme;+ global $custom_theme, $user;
This function grabs the user's current theme setting. Failing to invoke global $user may overlook a custom setting.
Attached minor correction to the module file.
The other 'big' code question is whether this module is now themed correctly. The only theme function I use format the individual table cells on the overview page. Drupal standards might mean that the whole themeswitcher_page() function go to a theme function.
#8
Fixed a dumb math error in the themeswitcher_page() logic.
#9
Fixed a missing & on line 281.
#10
First, lets make a real patch.