The hook_init() in automodal causes a problem when enabling both automodal and modalframe at the same time. In the event that automodal.module is loaded first, modalframe.module hasn't yet been enabled and leads to a PHP error:

( ! ) Fatal error: Call to undefined function modalframe_parent_js() in /Users/nate/Sites/drupal6/sites/all/modules/automodal/automodal.module on line 71

Worse yet the automodal module gets enabled but automodal does not, and since hook_init() fires on every page load the entire site is brought down and the administrator is unable to turn off the module. The only fix is to manually disable the module in the database, then turn them on one at a time.

Comments

rconstantine’s picture

rconstantine commented

That's strange. I thought that specifying dependent modules in the .info file was supposed to cover that sort of thing.

mfer’s picture

mfer commented
Status: Active » Fixed

I just experienced this. So annoying. Fixed. http://drupal.org/cvs?commit=408586

@rconstantine in D6 the dependency system installed dependencies but the order could be messed up. The install ordering is fixed in D7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

astutonet’s picture

astutonet
Location Sao Paulo, SP
commented
Status: Closed (fixed) » Active

Hello!

I'm testing this module. Initially, it seems to solve all my problems with modal windows.

However, I notice that there are still problems when the module is activated simultaneously with the module Modal Frame API, as follows:

Fatal error: Call to undefined function modalframe_parent_js() in C:\wamp\www\testes\sites\all\modules\automodal\automodal.module on line 51

On the page "MODULES", the Modal Frame API module is inactive, and no possibility to enable. It back to nomal only after we disable the Automodal module.

Unfortunately I can not find the solution presented in #2 above.

Any idea? Tks.

Marko B’s picture

Marko B commented

This is not problem with automodal but you probably didnt have properly jquery UI installed so you got that error.

astutonet’s picture

astutonet
Location Sao Paulo, SP
commented
Status: Active » Closed (won't fix)

As I hadn't answer in the time needed, the module has been uninstalled. However, the module jQuery_UI was correctly installed.

Marko B’s picture

Marko B commented

I got the same problem when jquery UI wasnt properly installed, and then automodal was installed although modal frame module wasn't because of JQ UI missing. and then this lins 51 happened to me also.