Files and Organic Groups [#823854]

I am working on a project that makes heavy use of OG. I noticed that when I enabled the Apache Solr OG module/facet block, it showed a number of search results showed up in "No Group". When I selected this filter, it appeared that only files were showing.

I'm not sure where the fix should be; should the apachesolr_og module figure out a file's gid by looking at the nodes it is attached to, or should apachesolr_attachments store the gid with the file?

Comment	File	Size	Author
#8	apachesolr_attachments.admin_.inc-823854-7.patch	1.02 KB	jsagotsky
#7	apachesolr_attachments.admin_.inc-823854-7.patch	1.02 KB	jsagotsky
#1	apachesolr_attachments.admin_.inc-823854.patch	1.49 KB	ebeyrent

Comments

Comment #1

ebeyrent commented 10 June 2010 at 14:01

Status	File	Size
new	apachesolr_attachments.admin_.inc-823854.patch	1.49 KB

After looking at this issue a bit more, I think that the fix should be in the apachesolr_attachments module, because it creates a separate Lucene document for each file it indexes. The attached patch simply adds the appropriate OG key to the document. After I patched the module and re-indexed my files, the problem appeared to be fixed.

Comment #2

ebeyrent commented 10 June 2010 at 14:01

Status:

Active

» Needs review

Comment #3

pwolanin commented 19 June 2010 at 01:56

Project:	Apache Solr Attachments	» Apache Solr Organic Groups Integration
Version:	6.x-2.x-dev	»
Status:	Needs review	» Needs work

No. This needs to be handled by the _og module. the attachments module should not know anything about groups.

Comment #4

pwolanin commented 19 June 2010 at 02:03

On approach is to use this hook:

      drupal_alter('apachesolr_attachment_index', $document, $node, $file);

The existing nodeaccess bit is a bit of an ugly hack and I'd rather not extend it.

ideally we should have a more generic hook that can alter documented created from or related to a specific node.

For 6.x-1.x I'm not sure sure a change is in scope - we coudl basiclaly use hook_apachesolr_update_index() if we indicate that modules implementing it may need to check $document->entity to decide whether to act, and maybe pass $entity as an option third parameter?