I just installed this module in a new site I am working on, and it works great, with one little glitch, though. The website in question is in Japanese, and I noticed that the trailing colons in the labels are not hidden. This is because Japanese uses double-byte characters, so the colon character code is different. Adding the following bit underneath line 37 in compact_forms.js did the trick for me:

lbl = lbl.replace(/:/,' ');

Now, I am not a programmer, so it may well be possible that my solution is a aberration and that there is a more elegant/appropriate way to fix this. But I thought I would share it anyway, in case you want to add this (or a better) solution to your module.

Thanks!

CommentFileSizeAuthor
#3 compact_forms-HEAD.utf8-colon.3.patch625 bytessun

Comments

ilfelice’s picture

Title: Add support for hiding double-byte semi-colon » Add support for hiding double-byte colon

Changed title.

sun’s picture

Version: 6.x-1.2 » 7.x-1.x-dev

We'd have to use Drupal.t(':') and then you can translate ':' via Locale -- pretty simple, now that I think about it.

sun’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new625 bytes

Technically, this should do it. Can you test?