(Using 0.4-alpha7)

When I migrate or clone a site, the files directory permission is set to the aegir user and not owned by the webserver until /after/ the verify is run.

When migrating a platform of sites this becomes a problem as the first verify doesn't run until all the migrations have completed. When dealing with large numbers of sites this could mean that sites are only partially useable (without the proper permission on files/) for several hours.

If the migration set the permissions on the files directory after it completed then this wouldn't be an issue.

Thanks!
- Scott

CommentFileSizeAuthor
#1 provision_823978.patch501 byteshadsie

Comments

hadsie’s picture

hadsie commented
StatusFileSize
new provision_823978.patch501 bytes
hadsie’s picture

hadsie commented
Status: Active » Needs review

The attached patch adds the directory and alias creation functions that I think are needed to make this happen.

anarcat’s picture

anarcat commented
Status: Needs review » Needs work

I think the patch is good, but a bad idea: I would rather see migrate run verify directly instead of queueing it. Why isn't it already like this?

adrian’s picture

adrian commented

Thinking about it, we're in a good place now to do that. 

 provision_backend_invoke(d()->name, 'provision-verify');

Now to decide wether it goes into post deploy or post migrate ('im thinking the latter')

hadsie’s picture

hadsie commented

yeah, that makes better sense. though if verify fails for some reason will that cause any issues with rolling back the migration?

adrian’s picture

adrian commented
Title: Set files directory permissions after site migrate or clone » Dont create an additional verify task when migrating
Status: Needs work » Fixed

I fixed this in head in the manner described.

it also will roll back completely if verification fails now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.