maxudit007 [maxudit007]

How is this proposed module different to the already existing modules for this purpose, for which there are definitely a couple? Why didn't you contribute to one of those module projects instead?

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per requirements, the proposed project must not duplicate the work done from existing projects. May you clarify in what your module is different from the already existing ones, as asked from sun?

It is important to not duplicate existing contributed modules/projects without good reason. As mentioned before, there are lots of existing advanced user management modules already, and the description you provided does not state a unique difference to those modules, or better yet, why a perhaps missing feature cannot be added to one of the existing modules instead. This is why we are asking for a clarification on why we need yet another user management module.

http://drupal.org/project/modules?filters=tid%3A76&solrsort=sis_project_... contains a list of all user management modules, which can be further filtered on certain search keywords.

Please understand that we are trying to keep the amount of contributed modules/projects sane and useful. Duplicating already existing projects without good reason is not really in the spirit of open source software. Therefore, new projects that are duplicating the ideas and efforts of existing projects should have a clear reason to do so.

In general, the Drupal community loves to collaborate, share, communicate, and joining forces with others. Duplicating stuff is considered a waste of time - both for developers, but even more importantly, also for users that are evaluating available modules.

Looking through the code of this module, it seems like it is duplicating a lot of modular functionality of the following, mostly matured modules:

- User (core)
- Profile (core)
- Views
- Views Bulk Operations
- Views Bonus Pack
- http://drupal.org/project/mailing_label (and similar modules)
- http://drupal.org/project/user_edit_notify (or similar)
- http://drupal.org/project/diff in combination with http://drupal.org/project/content_profile and others (instead of outdated Profile module)
- http://drupal.org/project/print

Overall, plenty of technically unrelated functionality has been squeezed into a single module here, which also makes this "module" very non-modular. The same functionality can be achieved - fully or partially, suitable for any use-case - through above mentioned and other existing modules. In turn, I guess that a large amount of development time went into this userdb.module, whereas the same functionality and business logic already exists and could have been implemented in almost no time through those existing modules.

A single, large module striving to provide this many features is most likely unusable for any other Drupal user, as most structures and settings are pre-defined and unalterable without hacking the module. In addition, the duplication of User and Profile modules on separate system paths and forms comes with an incompatibility to all other modules that provide features related to users and user profiles. In turn, the conclusion can be drawn that this module is only suitable for the original author.

Leaving final decision to someone else than me.

@sun: Thanks for the very detailed analysis of the code, and for the explanation you gave. Basing on your analysis, and on what maxudit007 kept to say, I am going to mark this application as won't fix.

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.