Hi

I found that privatemsg_attachment submodule (from Berdir, founded in some old issue, can't find it again)
don't work with more attachments than 1. In this case, only last attachment is shown and attached to private message.

CommentFileSizeAuthor
#11 attachments_multiple_files2.patch5.28 KBberdir
#1 attachments_multiple_files.patch3.75 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new attachments_multiple_files.patch3.75 KB

The attachments module is now part of the -dev release, so you don't need to look for it in some old issue :)

Confirmed the bug, try the attached patch. I was not able to write a test for this since multiple files doesn't seem to by supported by simletest.

Status: Needs review » Needs work

The last submitted patch, attachments_multiple_files.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

#1: attachments_multiple_files.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, attachments_multiple_files.patch, failed testing.

igorik’s picture

igorik commented

Would I test it although the notice is that patch fails? Is it what you wrote you I was not able to write a test for this?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I have no idea why the test fails, I can't reproduce it locally.

Yes, you can try the patch.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

#1: attachments_multiple_files.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, attachments_multiple_files.patch, failed testing.

igorik’s picture

igorik commented

Hi Berdir, the patch works nice and multiple attchements are now correctly sent and shown.
Thank you.

janwalhof’s picture

janwalhof commented

Thank you Berdir. Your patch in #1 made me happy today.

Regards,
Jan Walhof

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new attachments_multiple_files2.patch5.28 KB

I could now finally reproduce the test fails, this patch should fix them. I have however now clue why they suddently start appearing because of this patch.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Commited and fixed in 6.x-2.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.