Great module! I am using this for a digital download site at the moment. I have found the two formatters a bit over the top for my needs though, and spent a bit of time integrating the basic mp3 button style like what is used here: http://www.schillmania.com/projects/soundmanager2/demo/mp3-player-button/

Unfortunately i am not experienced with making patches or I would offer this, all I have is the hacked source code ... but I'd like to suggest that the basic button as a cck formatter would add value to the module. Great for showing small links and not cluttering the page too much .. I'm using it for providing a series of icon + text links in a block and it works nicely.

Thanks for your efforts!

CommentFileSizeAuthor
#6 soundmanager2.zip64.75 KB_paul_meta

Comments

_paul_meta’s picture

_paul_meta commented
Title: baisc mp3 button » basic mp3 button

I'd be happy to post a zip file of the module with the changes i put in to make this extra formatter if it helps, but I think its probably quite easy for the maintainers of the module. Still, let me know if that helps!

davebv’s picture

davebv commented

Thanks for your work! please, read this tutorial for creating patches for drupal http://drupal.org/patch/create. If you provide the patch, I cuold integrate it in the module and test it.

asb’s picture

asb commented

+

_paul_meta’s picture

_paul_meta commented

Hello :)

I have redone my changes to this module based on a clean version of soundmanager2-6.x-2.6 and its working nicely - I have a 3rd cck format for soundmanager2 which is a simple play/pause icon with the file name as text.

As this is not a simple patch but involves a new directory, file and alterations to multiple files I'm a bit lost as to how to create a patch for it (i'm not using cvs or git and have never made a patch before .. if it was a simple one file patch I would be ok but i'm not sure about the process for this more complex type of patch)

Alternately, i could make a zip file of the updated module package and post online for someone to make a patch.

Sorry for the delay on getting this done, life + work keeps me very busy.

Paul

davebv’s picture

davebv commented

Please, attach the .zip file and post the instructions I have to follow to incorporate to the module (i.e. what you did to integrate with he module, for example "copy the folder here/there")
Thanks and no need to say sorry, this is the beauty of drupal community. I am really busy and cannot involve myself in the drupal modules as much as I would like to.
Anyway, if you provide me with a zip file, I try to add it to the module.
Thanks again.

_paul_meta’s picture

_paul_meta commented
StatusFileSize
new soundmanager2.zip64.75 KB

Hi again :)

Thanks for this .. So i've attached the zip file of my altered version of the module. Its based on a clean version of soundmanager2-6.x-2.6 and assumes that the soundmanager2 package has been installed to /sites/all/libraries/soundmanager2

In the module folder, the following changes additions have been done:

1 - soundmanager2/sm2_plst_cck folder has a new file sm2_plst_cck_ff_link.tpl.php

2 - soundmanager2/sm2_plst_cck.module has some extra lines for the new cck formatter

3 - soundmanager2/players folder has a new file link.inc

4 - soundmanager2/players folder has a new folder link with the file link.css inside

The link.css file makes use of image files in the sites/all/libraries/soundmanager2 package. This can easily be changed if required.

So if you use my altered version of the module and clear drupal caches, a new output format should appear in content type display options and views.

Thanks for helping to incorporate these changes in to the module! I do hope to learn how to do a module patch soon but might try a simpler one file change first up, this is a bit more complex.

Let me know if any questions/issues!

Paul

davebv’s picture

davebv commented

Thanks for the zip. I just had a look at the code and I have a few suggestions in order to commit the changes.
About the filee "link.css", I feel there is a better way of referencing the images. Please, copy them to the "player/link" folder and use relative paths in the css.

In order to do that, please use the steps noted in this page: http://drupal.org/node/601496/cvs-instructions/DRUPAL-6--2
First, use cvs to clone the development copy.
cvs -z6 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -d soundmanager2-DRUPAL-6--2 -r DRUPAL-6--2 contributions/modules/soundmanager2/
Then, you will have a folder called soundmanager2-DRUPAL-6--2
Make your changes in that folder, modify /add the template files, add the player files like you did in your clean copy of 2.6.
After you have tested your changes, please create a patch:
cvs diff -up > ~/soundmanager2-825106-1.patch
Upload the new patch, this will make my life very much easier commiting your changes.

Thanks again for your contributions.