I wrote this patch to address several issues raised by some of my users...

  1. human readable group names
  2. confusing block/position interface
  3. how do we restrict where advertisers place advertisements

It addresses these issues by creating a vocabulary for the positions. And creating a block for each vocabulary term. Admittedly you lose the feature of being able to say you want 10 blocks, all displaying the same position, but advanced users can still create a php block that calls banner_display. I haven't tested it with taxonomy_access yet...

CommentFileSizeAuthor
#2 banner_taxonomy.patch_0.txt11.81 KBdopry
banner_taxonomy.patch.txt12.42 KBdopry

Comments

dopry’s picture

dopry commented
Status: Active » Needs review

oh yeah... I'd like some other eyes to take a look at it.

dopry’s picture

dopry commented
StatusFileSize
new banner_taxonomy.patch_0.txt11.81 KB

Here is one with a better clean up .install... The upgrade path needs work... it doesn't beak anything. you just have to create the terms manually and update all the banners... (sounds less than ideal eh?).... I will work on the upgrade path, more, but a functional install from base review would be nice.

wulff’s picture

wulff commented

ad 1) Human readable and definable group names is a very nice feature. A patch existed for the 4.6 version AFAIK but I haven't had the time to implement it.

ad 2) Absolutely. With the human readable names and a block per taxonomy term this is mostly solved, I think.

Re: "Taxonomy Specific Settings": Which settings do you think should be specific to each taxonomy term? Just width and height of the uploaded image or should it limit the types of banner for a given banner group?

Automatic resizing would be nice - upload the same image to the "big square banner" and "small square banner" groups and have them be resized differently. This would also allow us to ship the module with some of the standard banner sizes already set up (http://www.iab.net/standards/adunits.asp).

I have just made a couple of test banners, and the code so far seems to be working.

wulff’s picture

wulff commented
Status: Needs review » Fixed

User definable group names are now a part of the banner module.

marcoBauli’s picture

marcoBauli commented

Automatic resizing would be nice - upload the same image to the "big square banner" and "small square banner" groups and have them be resized differently. This would also allow us to ship the module with some of the standard banner sizes already set up.

Yes, this would be very handy. Actually how can the module tell what sizes are allowed for each Block? Should i specify it in another "instructions" page? Or make my terms more descriptive?

If admins could set in advance different typologies of banners to offer their users (Top Homepage banner, Left sidebar text ad, Single node banner,...) a lot of complicated settings could be avoided for the final users (more about this idea in this other issue here at #16.)

wulff’s picture

wulff commented
Title: Use a taxonomy vocabulary for banner positions. » Automatic resizing of banners
Status: Fixed » Active

Marking this feature request active. I'll look at automatic resizing when I port the module to 5.0.

Actually how can the module tell what sizes are allowed for each Block? Should i specify it in another "instructions" page? Or make my terms more descriptive?

I was thinking of making it a setting on the block configuration pages. Each block will have 'width' and 'height' fields to set the desired banner size.

dopry’s picture

dopry commented

I'll dig up a patch I have to do imagecache integration... for banner.module... It allows you to select imagecache presets per banner group taxonomy term.

dopry’s picture

dopry commented
Status: Active » Closed (fixed)