postgreSQL compatibility [#82623]

This module is not working in a postgreSQL environment yet. Here is the error I get when I post a comment onto a subscribed node:

    * warning: Invalid argument supplied for foreach() in /usr/share/drupal/modules/node.module on line 359.
    * warning: implode() [function.implode]: Bad arguments. in /usr/share/drupal/modules/node.module on line 363.
    * warning: pg_query() [function.pg-query]: Query failed: ERROR: syntax error at end of input at character 317 in /usr/share/drupal/includes/database.pgsql.inc on line 84.
    * user warning: query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.moderate, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /usr/share/drupal/includes/database.pgsql.inc on line 103.
    * warning: Invalid argument supplied for foreach() in /usr/share/drupal/modules/node.module on line 359.
    * warning: implode() [function.implode]: Bad arguments. in /usr/share/drupal/modules/node.module on line 363.
    * warning: pg_query() [function.pg-query]: Query failed: ERROR: syntax error at end of input at character 317 in /usr/share/drupal/includes/database.pgsql.inc on line 84.
    * user warning: query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.moderate, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /usr/share/drupal/includes/database.pgsql.inc on line 103.
    * warning: pg_query() [function.pg-query]: Query failed: ERROR: column "124" does not exist in /usr/share/drupal/includes/database.pgsql.inc on line 84.
    * user warning: query: SELECT tid FROM term_node WHERE nid = "124" in /usr/share/drupal/includes/database.pgsql.inc on line 103.
    * warning: Invalid argument supplied for foreach() in /usr/share/drupal/modules/node.module on line 359.
    * warning: implode() [function.implode]: Bad arguments. in /usr/share/drupal/modules/node.module on line 363.
    * warning: pg_query() [function.pg-query]: Query failed: ERROR: syntax error at end of input at character 317 in /usr/share/drupal/includes/database.pgsql.inc on line 84.
    * user warning: query: SELECT n.nid, n.vid, n.type, n.status, n.created, n.changed, n.comment, n.promote, n.moderate, n.sticky, r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE in /usr/share/drupal/includes/database.pgsql.inc on line 103.

Comment	File	Size	Author
#11	subscriptions.module.cvs_20061020.pgsql.patch	497 bytes	PMunn
#10	subscriptions.module.4.7.0.20060909.pgsql.patch	519 bytes	PMunn
#6	subscriptions.module_3.patch	862 bytes	JamieR
#4	subscriptions.module_2.patch	488 bytes	Steve Simms

Comments

Comment #1

dziemecki commented 6 September 2006 at 00:35

Are you using the code I checked in last night?

Comment #2

dboune commented 6 September 2006 at 20:56

Status:

Active

» Needs review

This feels like a kludge.. Why we are alternately receiving objects or arrays (or sometimes just nothing), I do not know.. but this fixes it for the time being, and hopefully exposes the real issue to someone who knows better than I.

Also, note the first change in the diff. Postgres doesn't like double quotes around values.

Thanks,
Damian

--- subscriptions.module.orig   2006-09-06 13:49:06.000000000 -0700
+++ subscriptions.module        2006-09-06 13:50:17.000000000 -0700
@@ -527,7 +527,7 @@
  * given a comment, return an array of associated taxonomies
  */
 function subscriptions_comment_taxa($comment){
-  $result = db_query('SELECT tid FROM {term_node} WHERE nid = "%s"', $comment['nid']);
+  $result = db_query('SELECT tid FROM {term_node} WHERE nid = \'%s\'', $comment['nid']);
   return db_fetch_object($result);
 }

@@ -537,7 +537,7 @@
 function subscriptions_comment($comment, $op) {
   global $user;
   $strsent = '!';
-  $nid = $comment->nid;
+  $nid = (is_array($comment)) ? $comment['nid'] : $comment->nid;
   if ($op == 'insert' || ($op == 'update' && $comment->status == 1)) { // ignore deactivated comments
     //  if use_cron is set, insert node actions into holding table
     if(variable_get('subscriptions_usecron', 0)){

Comment #3

JamieR commented 8 September 2006 at 07:02

Hi, Damian's patch has been working now without problem for a few days. Seems this issue may have been sorted out. I did upgrade to the latest distribution of the module - and the problem persisted. The patch was written for the latest 4.7 release. I hope this helps others - this module is an invaluable part of drupal. Thanks for all your work on it!

Jamie.
FYI, Damian and I work together.

Comment #4

Steve Simms commented 16 September 2006 at 02:50

Status	File	Size
new	subscriptions.module_2.patch	488 bytes

I just ran across the quoting problem that was mentioned above as well. Attached is an alternative patch, reversing the quotes rather than escaping them, which may be a little easier to read.

(Strictly speaking, since the nid should always be an integer, the quotes should be unnecessary in the first place, so that could be another possibility.)

Comment #5

sammys commented 16 September 2006 at 02:55

Status:

Needs review

» Needs work

Hi all,

This is a module, but I stumbled on this page through the issue queue. I'm of the mind that the variable be changed to %d and quotes removed. Please adjust this and i'll review the patch. I recommend always using double quotes around queries.

Cheers,
Sammy Spets
Synerger
http://synerger.com

Comment #6

JamieR commented 18 September 2006 at 17:06

Status:

Needs work

» Needs review

Status	File	Size
new	subscriptions.module_3.patch	862 bytes

Modified patch attached.

Comment #7

dziemecki commented 21 September 2006 at 00:48

Which version of the module is this patch against? Something like the patch listed at the top was already committed.

Comment #8

JamieR commented 24 September 2006 at 15:48

It was against the version that was commited on the night of Sept 5th... I'm not at work currently so I can't look at the file. Thanks!

Comment #9

sammys commented 9 October 2006 at 06:08

Status:

Needs review

» Needs work

The patch is broken and doesn't apply. Please resubmit the patch with the proper unified patch header.

Comment #10

PMunn commented 3 November 2006 at 05:26

Status:

Needs work

» Needs review

Status	File	Size
new	subscriptions.module.4.7.0.20060909.pgsql.patch	519 bytes

I ran into this, fixed it in 4.7.0, and fixed it (untested) in cvs.
The 4.7.0 patch based on the 2006-09-09 version is here...

Comment #11

PMunn commented 3 November 2006 at 05:27

Status	File	Size
new	subscriptions.module.cvs_20061020.pgsql.patch	497 bytes

And here is the cvs patch based on the 2006-10-20 cvs version:

Comment #12

dziemecki commented 5 November 2006 at 15:07

Assigned:	Unassigned	» dziemecki
Status:	Needs review	» Fixed

Corrected code committed.

Comment #13

PMunn commented 8 November 2006 at 02:13

Thank you. This latest 4.7.0 works for my postgresql install.

Comment #14

(not verified) commented 22 November 2006 at 02:15

Status:

Fixed

» Closed (fixed)

postgreSQL compatibility

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

News items

Our community

Documentation

Drupal code base

Governance of community