search_node_links not updating, for VALID links of the form href="/node/#/

Hi,

No I don't have Php filter enabled
I did mean the value of $node_regexp

and the single change you recommended worked, just added a preg_match check (or) for /
so
$node_regexp = '@href=[\'"]?(?:'. preg_quote($base_url, '@') .'/|'. preg_quote(base_path(), '@') .')(?:\?q=)?/?((?![a-z]+:)[^\'">]+)[\'">]@i';
becomes
$node_regexp = '@href=[\'"]?(?:'. preg_quote($base_url, '@') .'/|/|'. preg_quote(base_path(), '@') .')(?:\?q=)?/?((?![a-z]+:)[^\'">]+)[\'">]@i';

I was able to remove the other changes

>>>I can't see any way of avoiding having to patch search.module to get the behavior you require, because your links basically point to somewhere outside of your site.

Ok, well having drupal in a subdirectory and hiding, well leaving out, the subdirectory in links (links from my own pages or links to the site from outside) isnt that uncommon is it?

I did test and href="/subdirectory/node/##" works witout or with the hack to node_regex

using href="/node/##" Needs the hack to check for / to node_regex

Can I make a feature request to support Drupal in subdirectories like this?

Allan

Hi

Ill give a shorter statement of the requirment and then walk through it

*************Short version:

Currently Druapl Search only considers absolute links
<href="example.com/drupalbase"
and links realtive to the drupal base/subfolder
href="/drupalbase/..."

As being on the same site and there for as valid backlinks
(Where drupalbase is = base_path() )

The request or bug is that any links with a leading / as in href="/..." be consider links to the same site and hence indexed as backlinks. This is consistent with URL/link rules as I know them where href="/... assumes a relative link

Net - any html relative links be considered and indexed as a backlinks, not just ones pointing to drupalbase

is that clearer?

*************Long Version

I have basically drupal sitting in a folder /drupal but I do not need to put the subfolder name in the URLs

So these urls work wonderfully :
example.com/node/123
example.com/title-of-a-node (url alias)

Of course calls to
example.com/drupal/node/123
example.com/drupal/title-of-a-node

also work, but who wants that silly /drupal to have to be in all my references, links etc.

Anyway none of that is my issue, it all works and works fine so far with everything but backlinks

What I want to do is have destination links that go to another page, on one node pointing to another node, to look like

/node/123, or more fully <a href="node/123">Click Me</a>

Thats what I do do, it all works wonderfully

I dont want to have to do href="/drupal/node/123"

HOWEVER, search only backlinks these formats:
href="/drupal/node/123"
href="example.com/drupal/node/123"

>>add this to the node links table. How would that possibly work?

Look, the addition of two simple characters '/|' is all it took to make Drupal search support this subdirectory configuration

The search_node_links table simply look like this:

1 node 123 page-titile (Sid, Type, Nid, Caption)

It doesnt seem like a big complicated thing that Drupal has to figure out some magical stuff as you describe?
Actually this isnt asking drupal search to figure out anything, just asking if it could be less restrictive.

There is a check in search.module to see if the link points to a node on this site

// Check if link points to a node on this site
 if (preg_match($node_regexp, $value, $match)) {

because of the regular expression used this check only accepts :

href="example.com/drupal/ (an absolute link)
href="/drupal/ (a site relative link to the drupal base folder only)

I am asking that href="/... be recognized as relative to the same site and that drupal search have the forced requirement of the drupal physical subfolder.

Simply adding |/| as a condition, an OR statement, to the Regex accomplishes this.

What this in effect says is that if the link starts with a "/" then we assume it is relative to the site, and points ot another document on the site, and therefore counts as a backlink

Isnt that how href links work? anything with a leading / - like href="/.... is seen as relative to the root? on the same site?

I reject the notion, but open to comment, that my site config is something all that unique or special and this issue is in any way a one-off special for me. It sounds more to be about a basic assumption of what constitutes a 'link on this site' and current druapl search is to restrictive in its assumption.

So the real short version
Any links with a leading / as in href="/ be consider links to the same site and backlinks

Hope that at least clarifies the issue - thanks for your time

Well, if Drupal Search module - backlink subpart - wants to be narrow in scope to what it considers a valid backlink - not much I can do

I can point out that
Your restiction is limiting valid site implementation options and forcing longer and more complicated links.
Your arguments are that it will require something special of 'Drupal' is not even discussed and hardly proven.

I do want to point out that you write as if you speak for Drupal, but we are discussing a policy within a very narrow and specific function. Across Drupal this configuration is supported, and documented and even has configuration choices inside Drupal.
I run this configuration at several sites - so far nothiong but this little backlink code seems to care.

Any if you want to take a narrow interpration as to what constitutes a valid relative link within a website. one that is at odds with standard html rules, not much I can do.

Well I can state the my impression is that your points that Drupal Needs to Know or Guess at anything at all - is a facetious argument. If you could please explain in a bit more then hand waiving why backlinks are only vaid if druapl base is in the url?
What is it you need to Do or Know or Guess?

other then stop forcing a non-standard definiton of a site relative link.

Allan

I thought about this and the issue really is much narrow and specific then I wrote above.

Links of the form href="/node/123" are valid links on Drupal pages.
Drupal and Apache can be configured to make this work and I am not aware of any other issues with this form
This is not a one off or special

So, bug or feature, but Search backlinks should recognize this form of link as a valid 'internal' link

Using the counter logic presented so far, it seems safe to assume that /node/123 is pointing back to a drupal page

So curently Drupal Search, backlinks only supports absolute references or relative links with the basepath hardcoded in the link

Relative Links of the form '/node/123' should also be considered valid backlinks

The following mod checks to see if the basepath is in the link, and injects if not, but only for links like href="/node/123"

in search.module around line 496

if ($tagname == 'a') {

// MOD - Allows for node links of the form href="/node/123"
// Checks if the drupal base path is in the link if not add it - but only for /node style

   if (!preg_match(preg_quote(base_path(),'@'),$value)) {
      $value = str_ireplace('/node',base_path().'node',$value);
   }

//End

   // Check if link points to a node on this site
   if (preg_match($node_regexp, $value, $match)) {

[UPDATED]

Ahh ok, examples are helping

In your sceanario would you even be using href="/node/123/" for your links, in either domain?
be hard in the subdomain
Should be ok in the top domain

But your argument isnt valid is it? Your making this dire case that some really bad thing of having a one drupal domain report a backlink from a another drupal domain? Actually that sound pretty useful but not what Im talking about

My point is this almost species argument of how bad this would be - like your trying to make it sound bad, or dire, but perhaps you just dont get it, or I dont get it so lets walk through it.

The code I provided would insert base_path() for the domain search was running against as part of a condition

Sceanario-1
A base-drupal site has a Page with href="/node/123"
You run Search and build backlinks - what I am suggesting would work fine, no subdomain would be inserted in the links path
That Page would be listed as a backlink for Node 123 - no cross domain/site/instance issues

Sceanario-2
A subdir-drupal site has a Page with href="/node/123"
You run Search build backlinks - what I am suggesting would work fine, the subdomain would be inserted in the links path
That Page would be listed as a backlink for Node 123 - no cross domain/site/instance issues

Again, only the base_path for the domain that the search is running against would ever be used
The base_path is not part of the stored results, no data is corrupted

>>>The problem is that you cannot assume that a link like example.com/node/23 is a link *within the same drupal site* if Drupal is installed at example.com/subdir.

I still dont get what assumptions you think are going on? Where are assumptions being made? The base_path value for that site is being used, what is being assumed?

It still feels like your throwing up arguments for arguments sake, heels dug in and all, or one of us isnt thinking this through.

I am open and anxious to hearing any sceanarios of a standard drupal install where what Ive suggested actually breaks something

>> to handle non-standard Drupal installations

Could you explain what is NON STANDARD about my drupal installation?

A standard Drupal installation must be: _______________________________

Did someone change the title of this issue?

That is really uncalled for - what a crock to retitle something in such an inaccurate fashion - wow talk about politcal manuvering
sleezy

This is what was there today
search_node_links not updating, for links that are not within the Drupal installation

I am chaging it back to something that is closer to the truth of the issue