Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I validated my site with the W3C validator and got one error. The Custom Search Module uses the attribute target in a form tag, with is not supported. The id of the form is: "search-block-form".
Comments
Comment #1
jdanthinne CreditAttribution: jdanthinne commentedYou're right. I added the target attribute in case of the results are sent to another window.
I have to change it with javascript in order to validate. Please wait…
Comment #2
jdanthinne CreditAttribution: jdanthinne commentedFixed in DEV.
Please review.
Comment #3
onejam CreditAttribution: onejam commentedHi,
It seems to have fixed the XHTML 1.0 Strict validation thanks but i think the js is conflicting with IMCE module making IMCE image upload form fail to show up in popup window.
I can't be sure but when i rolled back from dev version to 6.x-1.4, IMCE suddenly worked again. So i am assuming there might be some conflict between this module and IMCE?
Tested with:
TinyMCE
Both IMCE 6.x-1.4 and 6.x-2.0-beta3
WYSIWYG API 6.x-2.1
IMCE Wysiwyg bridge 6.x-1.1
IMCE Mkdir 6.x-1.0
Also, will it still work if js was turned off? just concerned about web accessibility.
Thanks,
Comment #4
Everett Zufelt CreditAttribution: Everett Zufelt commentedUnder WCAG 2.0 (web content accessibility guidelines 2.0), the use of Javascript is not a concern for accessibility. However, it is important to make sure that the JS being used is accessible.
Comment #5
onejam CreditAttribution: onejam commentedOkay, thanks for letting me know that the accessibility isn't an issue. But i think the js is still conflicting with IMCE module in that you cannot view, upload images anymore. When i roll back to stable version (6.x-1.4) of custom search module, all was working fine again.
Thanks,
Comment #6
Everett Zufelt CreditAttribution: Everett Zufelt commentedJust to clarify, I haven't tested the accessibility of this module. I was just stating that Javascript in and of itself isn't necessarily an accessibility concern,
Of course the best development method is progressive enhancement, where functionality is enhanced by javascript, and is not dependent on it, not that this is possible in all cases.
Comment #7
jdanthinne CreditAttribution: jdanthinne commentedFixed the IMCE incompatibility in DEV.
Please review.
Comment #8
onejam CreditAttribution: onejam commentedThanks seems to be fixed now as i'm not experiencing any issues since updating to DEV version.
Comment #9
jdanthinne CreditAttribution: jdanthinne commentedComment #11
vasrush CreditAttribution: vasrush commentedRe-opening this issue.
I'm using custom search path (solr paths) styling with radio buttons and every single faceted search breaks
validation for using "/" in the attribute " id" and in the attribute "for".
I wasn't opened a new issue cause this is very similar to this one (breaking validation).
Thanks for this great module
Comment #12
vasrush CreditAttribution: vasrush commentedAnyone?
Can't find where in the code, these id are produced.
Not a php expert.
Comment #13
jdanthinne CreditAttribution: jdanthinne commentedHi,
the radios are not generated by the Custom Search module, but by Drupal Form API itself.
If you want to change that, you need to ovveride the theme_radio function.
Comment #14
heddnI'm taking some liberty but a support request from 2011 is probably fixed or irrelevant. If you disagree, please reopen and provide more details.